Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Unified Diff: chrome/renderer/chrome_render_view_observer.cc

Issue 13533019: Disables HTML notifications when rich notifications are enabled. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Indentation in test fixed. Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/chrome_render_view_observer.cc
diff --git a/chrome/renderer/chrome_render_view_observer.cc b/chrome/renderer/chrome_render_view_observer.cc
index 48651a7b8370133c3b8fac0b6ab1831db5e609d7..b4e6ea066a21e7b20bff389a5d949c975c15ce79 100644
--- a/chrome/renderer/chrome_render_view_observer.cc
+++ b/chrome/renderer/chrome_render_view_observer.cc
@@ -433,6 +433,10 @@ bool ChromeRenderViewObserver::allowWebComponents(const WebDocument& document,
bool ChromeRenderViewObserver::allowHTMLNotifications(
const WebDocument& document) {
+ CommandLine* command_line = CommandLine::ForCurrentProcess();
+ if (command_line->HasSwitch(switches::kDisableHTMLNotifications))
+ return false;
+
WebSecurityOrigin origin = document.securityOrigin();
const extensions::Extension* extension = GetExtension(origin);
return extension && extension->HasAPIPermission(APIPermission::kNotification);

Powered by Google App Engine
This is Rietveld 408576698