Storage Monitor: Remove MediaTransferProtocolDeviceObserverLinux::GetInstance() and access it only …

Storage Monitor: Remove MediaTransferProtocolDeviceObserverLinux::GetInstance() and access it only from StorageMonitor.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=192686

[Greg Billock, 2013-04-04 23:33:34]

https://codereview.chromium.org/13533009/diff/6001/chrome/browser/storage_mon...
File
chrome/browser/storage_monitor/media_transfer_protocol_device_observer_linux.cc
(right):

https://codereview.chromium.org/13533009/diff/6001/chrome/browser/storage_mon...
chrome/browser/storage_monitor/media_transfer_protocol_device_observer_linux.cc:174:
StorageLocationToInfoMap::const_iterator info_it =
Should we add another check here, like path_components[1] starts with "usb:" ?

[Lei Zhang, 2013-04-05 00:48:36]

https://codereview.chromium.org/13533009/diff/6001/chrome/browser/storage_mon...
File
chrome/browser/storage_monitor/media_transfer_protocol_device_observer_linux.cc
(right):

https://codereview.chromium.org/13533009/diff/6001/chrome/browser/storage_mon...
chrome/browser/storage_monitor/media_transfer_protocol_device_observer_linux.cc:174:
StorageLocationToInfoMap::const_iterator info_it =
On 2013/04/04 23:33:34, Greg Billock wrote:
> Should we add another check here, like path_components[1] starts with "usb:" ?

If it does not start with usb:, then we just won't find it and return false.
I'll add a check when adding to |storage_map_| in a separate CL.

[Greg Billock, 2013-04-05 23:21:59]

On 2013/04/05 00:48:36, Lei Zhang wrote:
>
https://codereview.chromium.org/13533009/diff/6001/chrome/browser/storage_mon...
> File
>
chrome/browser/storage_monitor/media_transfer_protocol_device_observer_linux.cc
> (right):
> 
>
https://codereview.chromium.org/13533009/diff/6001/chrome/browser/storage_mon...
>
chrome/browser/storage_monitor/media_transfer_protocol_device_observer_linux.cc:174:
> StorageLocationToInfoMap::const_iterator info_it =
> On 2013/04/04 23:33:34, Greg Billock wrote:
> > Should we add another check here, like path_components[1] starts with "usb:"
?
> 
> If it does not start with usb:, then we just won't find it and return false.
> I'll add a check when adding to |storage_map_| in a separate CL.

lgtm

[commit-bot: I haz the power, 2013-04-05 23:25:23]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/thestig@chromium.org/13533009/14001

[commit-bot: I haz the power, 2013-04-06 01:36:07]

Change committed as 192686