Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(563)

Unified Diff: chrome/browser/storage_monitor/media_transfer_protocol_device_observer_linux.cc

Issue 13533009: Storage Monitor: Remove MediaTransferProtocolDeviceObserverLinux::GetInstance() and access it only … (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: rebase Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/storage_monitor/media_transfer_protocol_device_observer_linux.cc
===================================================================
--- chrome/browser/storage_monitor/media_transfer_protocol_device_observer_linux.cc (revision 192467)
+++ chrome/browser/storage_monitor/media_transfer_protocol_device_observer_linux.cc (working copy)
@@ -4,6 +4,8 @@
#include "chrome/browser/storage_monitor/media_transfer_protocol_device_observer_linux.h"
+#include <vector>
+
#include "base/files/file_path.h"
#include "base/stl_util.h"
#include "base/strings/string_number_conversions.h"
@@ -120,8 +122,9 @@
} // namespace
MediaTransferProtocolDeviceObserverLinux::
-MediaTransferProtocolDeviceObserverLinux()
- : get_storage_info_func_(&GetStorageInfo) {
+MediaTransferProtocolDeviceObserverLinux(StorageMonitor::Receiver* receiver)
+ : get_storage_info_func_(&GetStorageInfo),
+ notifications_(receiver) {
DCHECK(!g_mtp_device_observer);
g_mtp_device_observer = this;
@@ -135,9 +138,10 @@
// This constructor is only used by unit tests.
MediaTransferProtocolDeviceObserverLinux::
MediaTransferProtocolDeviceObserverLinux(
+ StorageMonitor::Receiver* receiver,
GetStorageInfoFunc get_storage_info_func)
: get_storage_info_func_(get_storage_info_func),
- notifications_(NULL) {
+ notifications_(receiver) {
DCHECK(!g_mtp_device_observer);
g_mtp_device_observer = this;
}
@@ -153,13 +157,6 @@
mtp_manager->RemoveObserver(this);
}
-// static
-MediaTransferProtocolDeviceObserverLinux*
-MediaTransferProtocolDeviceObserverLinux::GetInstance() {
- DCHECK(g_mtp_device_observer != NULL);
- return g_mtp_device_observer;
-}
-
bool MediaTransferProtocolDeviceObserverLinux::GetStorageInfoForPath(
const base::FilePath& path,
StorageInfo* storage_info) const {
@@ -184,11 +181,6 @@
return true;
}
-void MediaTransferProtocolDeviceObserverLinux::SetNotifications(
- StorageMonitor::Receiver* notifications) {
- notifications_ = notifications;
-}
-
// device::MediaTransferProtocolManager::Observer override.
void MediaTransferProtocolDeviceObserverLinux::StorageChanged(
bool is_attached,

Powered by Google App Engine
This is Rietveld 408576698