History Action Pop-ups incorrect behavior when document is scrolled.

History Action Pop-ups incorrect behavior when document is scrolled.

The Menu Button ui control that the history action pop-ups employ
handle the resize event by hiding the menu.  This CL will similarly
hide the menu on a |scroll| event is triggered.

This resolves the scrolling problem in the referenced bug.

However, this change does not address the reported behavior that the
pop-up remains visible when changing tabs. I tend to agree with
sergiu@ that the existing behavior seems proper.

BUG=222313
TEST=The MenuButton ui element is used in several places; I tested the History, Bookmark Manager and NTP but I can see it also being used in ChromeOS login screen and File Manager which I am unable to test. The change involves hiding the menu pop-up when the document scroll event is triggered.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=192489

[Dan Beam, 2013-04-04 20:00:48]

have you tried this on any other clients of this class (i.e. settings)?  in
general, I think this will fix many many bugs, so I'm willing to give it a try
either way, lgtm.

[Tom Cassiotis, 2013-04-05 01:19:49]

On 2013/04/04 20:00:48, Dan Beam wrote:
> have you tried this on any other clients of this class (i.e. settings)?  in
> general, I think this will fix many many bugs, so I'm willing to give it a try
> either way, lgtm.

I did take a look at it's uses.  I mentioned them in the TEST= portion.  I
tested History, Bookmark Manager and NTP, but I could not see it's use in
Settings.  Also I couldn't test the File Manager and ChromeOS login screens.

The three I tested worked well and the Bookmark Manager had the same bug as
History.

Going to land this now.

[Dan Beam, 2013-04-05 01:21:40]

On 2013/04/05 01:19:49, Tom Cassiotis wrote:
> On 2013/04/04 20:00:48, Dan Beam wrote:
> > have you tried this on any other clients of this class (i.e. settings)?  in
> > general, I think this will fix many many bugs, so I'm willing to give it a
try
> > either way, lgtm.
> 
> I did take a look at it's uses.  I mentioned them in the TEST= portion.  I
> tested History, Bookmark Manager and NTP, but I could not see it's use in
> Settings.

ah, just grepped, nvm it's not used there

>  Also I couldn't test the File Manager and ChromeOS login screens.
> 
> The three I tested worked well and the Bookmark Manager had the same bug as
> History.
> 
> Going to land this now.

go ahead

[commit-bot: I haz the power, 2013-04-05 02:07:26]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tom.cassiotis@gmail.com/13532014/1

[commit-bot: I haz the power, 2013-04-05 04:02:04]

Change committed as 192489