ui/webui/resources/js/cr/ui/menu_button.js - Issue 13532014: History Action Pop-ups incorrect behavior when document is scrolled.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/webui/resources/js/cr/ui/menu_button.js

Issue 13532014: History Action Pop-ups incorrect behavior when document is scrolled. (Closed) Base URL: https://src.chromium.org/chrome/trunk/src/

Patch Set: Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ui/webui/resources/js/cr/ui/menu_button.js

===================================================================

--- ui/webui/resources/js/cr/ui/menu_button.js (revision 188725)

+++ ui/webui/resources/js/cr/ui/menu_button.js (working copy)

@@ -132,6 +132,7 @@

e.target.checkable;

this.hideMenu(hideDelayed ? HideType.DELAYED : HideType.INSTANT);

break;

+ case 'scroll':

case 'resize':

this.hideMenu();

break;

@@ -164,6 +165,7 @@

this.showingEvents_.add(doc, 'keydown', this, true);

this.showingEvents_.add(doc, 'mousedown', this, true);

this.showingEvents_.add(doc, 'focus', this, true);

+ this.showingEvents_.add(doc, 'scroll', this, true);

this.showingEvents_.add(win, 'resize', this);

this.showingEvents_.add(this.menu, 'activate', this);

this.positionMenu_();

« no previous file with comments | « no previous file | no next file » | no next file with comments »