Improve javac action output

build/android/gyp/javac.py

Index: build/android/gyp/javac.py
diff --git a/build/android/gyp/javac.py b/build/android/gyp/javac.py
index b22d05bd77a6c295a852bbe8942d0e7fb41a2639..8a62e5f994f51a9e2358583abe107c7144737edf 100755
--- a/build/android/gyp/javac.py
+++ b/build/android/gyp/javac.py
@@ -47,16 +47,13 @@ def DoJavac(options):
       '-source', '1.5',
       '-target', '1.5',
       '-classpath', ':'.join(classpath),
-      '-d', output_dir]
+      '-d', output_dir,
+      '-Xlint:unchecked',
+      '-Xlint:deprecation',
+      ]
 
-  # Only output Java warnings for chromium code
-  if options.chromium_code:
-    cmd += ['-Xlint:unchecked']
-  else:
-    cmd += [# Suppress "Sun proprietary API" warnings. See: goo.gl/OYxUM
-            '-XDignore.symbol.file']
-
-  build_utils.CheckCallDie(cmd + java_files)
+  suppress_output = not options.chromium_code
+  build_utils.CheckCallDie(cmd + java_files, suppress_output=suppress_output)

[newt (away), 2013/04/04 02:00:47]

suppress_output causes us to print the output iff the command fails, right?

[cjhopman, 2013/04/05 00:11:29]

correct.

 
 def main(argv):
   parser = optparse.OptionParser()