Improve javac action output

build/android/gyp/javac.py

 #!/usr/bin/env python
 #
 # Copyright 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import fnmatch
 import optparse
 import os
 import sys
@@ skipping 29 matching lines @@
   # not contain the corresponding old .class file after running this action.
   build_utils.DeleteDirectory(output_dir)
   build_utils.MakeDirectory(output_dir)
 
   cmd = [
       'javac',
       '-g',
       '-source', '1.5',
       '-target', '1.5',
       '-classpath', ':'.join(classpath),
-      '-d', output_dir]
+      '-d', output_dir,
+      '-Xlint:unchecked',
+      '-Xlint:deprecation',
+      ]
 
-  # Only output Java warnings for chromium code
-  if options.chromium_code:
-    cmd += ['-Xlint:unchecked']
-  else:
-    cmd += [# Suppress "Sun proprietary API" warnings. See: goo.gl/OYxUM
-            '-XDignore.symbol.file']
-
-  build_utils.CheckCallDie(cmd + java_files)
+  suppress_output = not options.chromium_code
+  build_utils.CheckCallDie(cmd + java_files, suppress_output=suppress_output)

[newt (away), 2013/04/04 02:00:47]

suppress_output causes us to print the output iff the command fails, right?

[cjhopman, 2013/04/05 00:11:29]

correct.

 
 def main(argv):
   parser = optparse.OptionParser()
   parser.add_option('--src-dirs', help='Directories containing java files.')
   parser.add_option('--javac-includes',
       help='A list of file patterns. If provided, only java files that match' +
         'one of the patterns will be compiled.')
   parser.add_option('--classpath', help='Classpath for javac.')
   parser.add_option('--output-dir', help='Directory for javac output.')
   parser.add_option('--stamp', help='Path to touch on success.')
   parser.add_option('--chromium-code', type='int', help='Whether code being '
                     'compiled should be built with stricter warnings for '
                     'chromium code.')
 
   # TODO(newt): remove this once http://crbug.com/177552 is fixed in ninja.
   parser.add_option('--ignore', help='Ignored.')
 
   options, _ = parser.parse_args()
 
   DoJavac(options)
 
   if options.stamp:
     build_utils.Touch(options.stamp)
 
 
 if __name__ == '__main__':
   sys.exit(main(sys.argv))