Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(278)

Issue 13489006: Improve javac action output (Closed)

Created:
7 years, 8 months ago by cjhopman
Modified:
7 years, 8 months ago
Reviewers:
newt (away)
CC:
chromium-reviews, klundberg+watch_chromium.org, frankf+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy+watch_chromium.org
Visibility:
Public.

Description

Improve javac action output For non-chromium code, suppress all output when successful (i.e. warnings). For chromium code, add -Xlint:deprecation to get detailed deprecation warnings. BUG=164395 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=192479

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -9 lines) Patch
M build/android/gyp/javac.py View 1 chunk +6 lines, -9 lines 2 comments Download

Messages

Total messages: 5 (0 generated)
cjhopman
7 years, 8 months ago (2013-04-04 00:59:17 UTC) #1
newt (away)
lgtm, as long as my assumption about suppress_output is correct https://codereview.chromium.org/13489006/diff/1/build/android/gyp/javac.py File build/android/gyp/javac.py (right): https://codereview.chromium.org/13489006/diff/1/build/android/gyp/javac.py#newcode56 ...
7 years, 8 months ago (2013-04-04 02:00:46 UTC) #2
cjhopman
https://codereview.chromium.org/13489006/diff/1/build/android/gyp/javac.py File build/android/gyp/javac.py (right): https://codereview.chromium.org/13489006/diff/1/build/android/gyp/javac.py#newcode56 build/android/gyp/javac.py:56: build_utils.CheckCallDie(cmd + java_files, suppress_output=suppress_output) On 2013/04/04 02:00:47, newt wrote: ...
7 years, 8 months ago (2013-04-05 00:11:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cjhopman@chromium.org/13489006/1
7 years, 8 months ago (2013-04-05 00:12:52 UTC) #4
commit-bot: I haz the power
7 years, 8 months ago (2013-04-05 03:42:34 UTC) #5
Message was sent while issue was closed.
Change committed as 192479

Powered by Google App Engine
This is Rietveld 408576698