Issue 13485004: Extract GetSerialNumber() from inner loop

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 13485004: Extract GetSerialNumber() from inner loop (Closed)

Created:
7 years, 8 months ago by cjhopman

Modified:
7 years, 8 months ago

Reviewers:
nilesh

CC:
chromium-reviews, klundberg+watch_chromium.org, frankf+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Extract GetSerialNumber() from inner loop This call is a bit slow, and is especially noticeable when only few/no libraries need to be pushed. Also, we only need to write the new md5 stamp if it has actually changed (i.e. it is stale). BUG=158821 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=192454

Patch Set 1 #

Total comments: 1

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -2 lines)			Patch
	M	build/android/gyp/push_libraries.py	View		1 chunk	+3 lines, -2 lines	1 comment	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

nilesh

https://codereview.chromium.org/13485004/diff/1/build/android/gyp/push_libraries.py File build/android/gyp/push_libraries.py (left): https://codereview.chromium.org/13485004/diff/1/build/android/gyp/push_libraries.py#oldcode34 build/android/gyp/push_libraries.py:34: md5_stamp = '%s.%s.md5' % (host_path, adb.Adb().GetSerialNumber()) nit:md5_stamp_file is a ...

7 years, 8 months ago (2013-04-04 16:48:24 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cjhopman@chromium.org/13485004/1

7 years, 8 months ago (2013-04-05 00:10:44 UTC) #4

Message was sent while issue was closed.

Change committed as 192454

Expand Messages | Collapse Messages