Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2591)

Unified Diff: build/android/gyp/push_libraries.py

Issue 13485004: Extract GetSerialNumber() from inner loop (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/android/gyp/push_libraries.py
diff --git a/build/android/gyp/push_libraries.py b/build/android/gyp/push_libraries.py
index a6dc45b29211c9d11adc0efa368da7b77a80a2fb..e586d0be6d577e19a0ba585d10df73702b0e9aeb 100755
--- a/build/android/gyp/push_libraries.py
+++ b/build/android/gyp/push_libraries.py
@@ -26,19 +26,20 @@ def DoPush(options):
libraries = build_utils.ReadJson(options.libraries_json)
adb = android_commands.AndroidCommands()
+ serial_number = adb.Adb().GetSerialNumber()
needs_directory = True
for lib in libraries:
device_path = os.path.join(options.device_dir, lib)
host_path = os.path.join(options.libraries_dir, lib)
- md5_stamp = '%s.%s.md5' % (host_path, adb.Adb().GetSerialNumber())
nilesh 2013/04/04 16:48:24 nit:md5_stamp_file is a better name for var
+ md5_stamp = '%s.%s.push.md5' % (host_path, serial_number)
md5_checker = md5_check.Md5Checker(stamp=md5_stamp, inputs=[host_path])
if md5_checker.IsStale():
if needs_directory:
adb.RunShellCommand('mkdir ' + options.device_dir)
needs_directory = False
adb.PushIfNeeded(host_path, device_path)
- md5_checker.Write()
+ md5_checker.Write()
def main(argv):
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698