Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Issue 13483007: Don't set MODE_DEFAULT when adding HPKP header. (Closed)

Created:
7 years, 8 months ago by palmer
Modified:
7 years, 8 months ago
Reviewers:
ananta, agl, Ryan Sleevi
CC:
chromium-reviews, cbentzel+watch_chromium.org
Visibility:
Public.

Description

Don't set MODE_DEFAULT when adding HPKP header. Leave that to the default value, or whatever value an HSTS header set. TEST=net_unittests; after visiting https://www.mv-rechberghausen.de, query that domain in chrome://net-internal/#hsts and expect pins AND mode STRICT. BUG=226068 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=193443

Patch Set 1 #

Patch Set 2 : Beginnings of a test; more to come. #

Patch Set 3 : Give that CLeevi a test. CLeevis love tests. #

Patch Set 4 : Hide the broken test from Android. #

Patch Set 5 : Just a hunch... #

Patch Set 6 : Rebase, remove junk #

Patch Set 7 : Disable new test on Chrome Frame since it can't work. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -22 lines) Patch
M chrome_frame/test/net/fake_external_tab.cc View 1 2 3 4 5 6 1 chunk +3 lines, -2 lines 0 comments Download
A + net/data/url_request_unittest/hsts-and-hpkp-headers.html View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A net/data/url_request_unittest/hsts-and-hpkp-headers.html.mock-http-headers View 1 2 3 4 1 chunk +8 lines, -0 lines 0 comments Download
M net/http/http_security_headers.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M net/http/http_security_headers_unittest.cc View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M net/http/transport_security_state.h View 1 2 3 1 chunk +3 lines, -4 lines 0 comments Download
M net/http/transport_security_state.cc View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M net/http/transport_security_state_unittest.cc View 1 2 3 1 chunk +6 lines, -12 lines 0 comments Download
M net/url_request/url_request_unittest.cc View 1 2 3 4 5 6 1 chunk +39 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
palmer
7 years, 8 months ago (2013-04-03 21:40:42 UTC) #1
agl
lgtm
7 years, 8 months ago (2013-04-03 21:46:35 UTC) #2
Ryan Sleevi
Can you please add a new unittest for this? Should be as simple as adding ...
7 years, 8 months ago (2013-04-03 21:52:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/palmer@chromium.org/13483007/8001
7 years, 8 months ago (2013-04-04 17:56:18 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/palmer@chromium.org/13483007/8001
7 years, 8 months ago (2013-04-04 20:05:32 UTC) #5
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 8 months ago (2013-04-04 20:07:25 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/palmer@chromium.org/13483007/44002
7 years, 8 months ago (2013-04-08 22:26:15 UTC) #7
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) chrome_frame_net_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=132280
7 years, 8 months ago (2013-04-09 01:49:49 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/palmer@chromium.org/13483007/62001
7 years, 8 months ago (2013-04-09 19:48:10 UTC) #9
commit-bot: I haz the power
Presubmit check for 13483007-62001 failed and returned exit status 1. INFO:root:Found 9 file(s). Running presubmit ...
7 years, 8 months ago (2013-04-09 19:48:23 UTC) #10
palmer
Ananta, can I please get an OWNERS LGTM for the Chrome Frame file? Thanks.
7 years, 8 months ago (2013-04-09 20:07:01 UTC) #11
ananta
lgtm
7 years, 8 months ago (2013-04-10 17:55:19 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/palmer@chromium.org/13483007/62001
7 years, 8 months ago (2013-04-10 17:58:23 UTC) #13
commit-bot: I haz the power
7 years, 8 months ago (2013-04-10 20:24:38 UTC) #14
Message was sent while issue was closed.
Change committed as 193443

Powered by Google App Engine
This is Rietveld 408576698