net/http/transport_security_state.h - Issue 13483007: Don't set MODE_DEFAULT when adding HPKP header.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/http/transport_security_state.h

Issue 13483007: Don't set MODE_DEFAULT when adding HPKP header. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Disable new test on Chrome Frame since it can't work. Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/http/transport_security_state.h

diff --git a/net/http/transport_security_state.h b/net/http/transport_security_state.h

index a4e3f33b7641c9f414ab9362755fc99bdf8d18c9..933c86c820b6f4193922f3382b3c2b542720dc5b 100644

--- a/net/http/transport_security_state.h

+++ b/net/http/transport_security_state.h

@@ -108,10 +108,9 @@ class NET_EXPORT TransportSecurityState

// Are subdomains subject to this DomainState?

- // TODO(palmer): Decide if we should have separate |pin_subdomains| and

- // |upgrade_subdomains|. Alternately, and perhaps better, is to separate

- // DomainState into UpgradeState and PinState (requiring also changing the

- // serialization format?).

+ // TODO(palmer): We need to have separate |pin_subdomains| and

+ // |upgrade_subdomains|. Trevor Perrin is working on a new storage model

+ // that will enable this.

bool include_subdomains;

// Optional; hashes of static pinned SubjectPublicKeyInfos. Unless both

« no previous file with comments | « net/http/http_security_headers_unittest.cc ('k') | net/http/transport_security_state.cc » ('j') | no next file with comments »