Folded GraphicsContext3DChromium into GraphicsContext3D

Folded GraphicsContext3DChromium into GraphicsContext3D


BUG=227316

[bajones, 2013-04-08 04:06:18]

One of the first steps of several to streamline WebGL's implementation in Blink.
This one is fairly invisible to the rest of the code base, so it's a good
candidate to land during the "great blink code purge".

[Zhenyao Mo, 2013-04-08 17:41:15]

https://codereview.chromium.org/13474014/diff/1/Source/WebCore/platform/graph...
File Source/WebCore/platform/graphics/GraphicsContext3D.cpp (right):

https://codereview.chromium.org/13474014/diff/1/Source/WebCore/platform/graph...
Source/WebCore/platform/graphics/GraphicsContext3D.cpp:431: return
m_private->webContext()->getProgramInfoLog(program);
This can use macro.

https://codereview.chromium.org/13474014/diff/1/Source/WebCore/platform/graph...
Source/WebCore/platform/graphics/GraphicsContext3D.cpp:439: return
m_private->webContext()->getShaderInfoLog(shader);
This can use macro.

https://codereview.chromium.org/13474014/diff/1/Source/WebCore/platform/graph...
Source/WebCore/platform/graphics/GraphicsContext3D.cpp:446: return
m_private->webContext()->getShaderSource(shader);
This can use macro.

https://codereview.chromium.org/13474014/diff/1/Source/WebCore/platform/graph...
Source/WebCore/platform/graphics/GraphicsContext3D.cpp:451: return
m_private->webContext()->getString(name);
This can use macro.

https://codereview.chromium.org/13474014/diff/1/Source/WebCore/platform/graph...
Source/WebCore/platform/graphics/GraphicsContext3D.cpp:502:
m_private->webContext()->texImage2D(target, level, internalformat, width,
height, border, format, type, pixels);
We probably should get rid of the return bool and just use macro for this
function.

https://codereview.chromium.org/13474014/diff/1/Source/WebCore/platform/graph...
Source/WebCore/platform/graphics/GraphicsContext3D.cpp:511:
m_private->webContext()->texSubImage2D(target, level, xoffset, yoffset, width,
height, format, type, pixels);
this one could just use the macro.

[Ken Russell (switch to Gerrit), 2013-04-08 19:13:04]

LGTM with Mo's review items addressed.

https://codereview.chromium.org/13474014/diff/1/Source/WebCore/platform/graph...
File Source/WebCore/platform/graphics/GraphicsContext3D.cpp (right):

https://codereview.chromium.org/13474014/diff/1/Source/WebCore/platform/graph...
Source/WebCore/platform/graphics/GraphicsContext3D.cpp:502:
m_private->webContext()->texImage2D(target, level, internalformat, width,
height, border, format, type, pixels);
On 2013/04/08 17:41:15, Zhenyao Mo wrote:
> We probably should get rid of the return bool and just use macro for this
> function.

Agree with getting rid of the no-op bool return value.

[bajones1, 2013-04-08 20:18:20]

Addressed Mo's feedback

[Ken Russell (switch to Gerrit), 2013-04-08 22:30:42]

Landed on behalf of bajones in https://codereview.chromium.org/13592004/ .