Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(714)

Issue 13473017: CheckCallDie: add option to suppress successful output (Closed)

Created:
7 years, 8 months ago by cjhopman
Modified:
7 years, 8 months ago
Reviewers:
nilesh
CC:
chromium-reviews, klundberg+watch_chromium.org, frankf+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy+watch_chromium.org
Visibility:
Public.

Description

CheckCallDie: add option to suppress successful output Some commands that are called by build scripts are particularly verbose (ant, dex, readelf). For these commands, the output (when successful) is not useful (unlike javac, for example). Add an option (suppress_output) to build_util.CheckCallDie to disable printing of stdout/stderr when the call is successful. Also, move remaining build scripts in build/android to build/android/gyp. NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=192409

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : :/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -419 lines) Patch
D build/android/create_native_libraries_header.py View 1 chunk +0 lines, -52 lines 0 comments Download
D build/android/gcc_preprocess.py View 1 chunk +0 lines, -52 lines 0 comments Download
M build/android/gyp/apk_install.py View 1 2 chunks +2 lines, -5 lines 0 comments Download
M build/android/gyp/create_device_library_links.py View 1 chunk +2 lines, -1 line 0 comments Download
A + build/android/gyp/create_native_libraries_header.py View 1 chunk +1 line, -1 line 0 comments Download
M build/android/gyp/dex.py View 2 chunks +2 lines, -6 lines 0 comments Download
A + build/android/gyp/gcc_preprocess.py View 1 chunk +1 line, -1 line 0 comments Download
M build/android/gyp/jar.py View 1 chunk +1 line, -5 lines 0 comments Download
M build/android/gyp/javac.py View 1 chunk +1 line, -3 lines 0 comments Download
A + build/android/gyp/process_resources.py View 1 2 chunks +2 lines, -2 lines 0 comments Download
M build/android/gyp/push_libraries.py View 1 chunk +1 line, -1 line 0 comments Download
A + build/android/gyp/strip_library_for_apk.py View 1 chunk +1 line, -1 line 0 comments Download
A + build/android/gyp/util/build_utils.py View 2 chunks +2 lines, -2 lines 0 comments Download
M build/android/gyp/write_ordered_libraries.py View 2 chunks +2 lines, -5 lines 0 comments Download
M build/android/java_cpp_template.gypi View 1 chunk +3 lines, -3 lines 0 comments Download
D build/android/process_resources.py View 1 chunk +0 lines, -97 lines 0 comments Download
D build/android/pylib/build_utils.py View 1 chunk +0 lines, -103 lines 0 comments Download
D build/android/strip_library_for_apk.py View 1 chunk +0 lines, -57 lines 0 comments Download
M build/java.gypi View 1 2 3 5 chunks +6 lines, -6 lines 0 comments Download
M build/java_apk.gypi View 10 chunks +15 lines, -15 lines 0 comments Download
M build/java_prebuilt.gypi View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
cjhopman
7 years, 8 months ago (2013-04-02 23:26:04 UTC) #1
nilesh
On 2013/04/02 23:26:04, cjhopman wrote: LGTM
7 years, 8 months ago (2013-04-03 00:44:17 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cjhopman@chromium.org/13473017/28001
7 years, 8 months ago (2013-04-04 15:29:08 UTC) #3
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 8 months ago (2013-04-04 19:03:23 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cjhopman@chromium.org/13473017/28001
7 years, 8 months ago (2013-04-04 19:55:04 UTC) #5
commit-bot: I haz the power
7 years, 8 months ago (2013-04-04 23:04:44 UTC) #6
Message was sent while issue was closed.
Change committed as 192409

Powered by Google App Engine
This is Rietveld 408576698