Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Side by Side Diff: build/android/pylib/build_utils.py

Issue 13473017: CheckCallDie: add option to suppress successful output (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: :/ Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « build/android/process_resources.py ('k') | build/android/strip_library_for_apk.py » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
(Empty)
1 # Copyright 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file.
4
5 import fnmatch
6 import json
7 import os
8 import pipes
9 import shlex
10 import shutil
11 import subprocess
12 import sys
13 import traceback
14
15
16 def MakeDirectory(dir_path):
17 try:
18 os.makedirs(dir_path)
19 except OSError:
20 pass
21
22
23 def DeleteDirectory(dir_path):
24 if os.path.exists(dir_path):
25 shutil.rmtree(dir_path)
26
27
28 def Touch(path):
29 MakeDirectory(os.path.dirname(path))
30 with open(path, 'a'):
31 os.utime(path, None)
32
33
34 def FindInDirectory(directory, filter):
35 files = []
36 for root, dirnames, filenames in os.walk(directory):
37 matched_files = fnmatch.filter(filenames, filter)
38 files.extend((os.path.join(root, f) for f in matched_files))
39 return files
40
41
42 def FindInDirectories(directories, filter):
43 all_files = []
44 for directory in directories:
45 all_files.extend(FindInDirectory(directory, filter))
46 return all_files
47
48
49 def ParseGypList(gyp_string):
50 # The ninja generator doesn't support $ in strings, so use ## to
51 # represent $.
52 # TODO(cjhopman): Remove when
53 # https://code.google.com/p/gyp/issues/detail?id=327
54 # is addressed.
55 gyp_string = gyp_string.replace('##', '$')
56 return shlex.split(gyp_string)
57
58
59 def CheckOptions(options, parser, required=[]):
60 for option_name in required:
61 if not getattr(options, option_name):
62 parser.error('--%s is required' % option_name.replace('_', '-'))
63
64
65 def ReadJson(path):
66 with open(path, 'r') as jsonfile:
67 return json.load(jsonfile)
68
69
70 # This can be used in most cases like subprocess.check_call. The output,
71 # particularly when the command fails, better highlights the command's failure.
72 # This call will directly exit on a failure in the subprocess so that no python
73 # stacktrace is printed after the output of the failed command.
74 def CheckCallDie(args, cwd=None):
75 if not cwd:
76 cwd = os.getcwd()
77
78 child = subprocess.Popen(args,
79 stdout=subprocess.PIPE, stderr=subprocess.STDOUT, cwd=cwd)
80
81 stdout, _ = child.communicate()
82
83 if child.returncode:
84 stacktrace = traceback.extract_stack()
85 print >> sys.stderr, ''.join(traceback.format_list(stacktrace))
86 # A user should be able to simply copy and paste the command that failed
87 # into their shell.
88 copyable_command = ' '.join(map(pipes.quote, args))
89 copyable_command = ('( cd ' + os.path.abspath(cwd) + '; '
90 + copyable_command + ' )')
91 print >> sys.stderr, 'Command failed:', copyable_command, '\n'
92
93 if stdout:
94 print stdout,
95
96 # Directly exit to avoid printing stacktrace.
97 sys.exit(child.returncode)
98
99 else:
100 if stdout:
101 print stdout,
102 return stdout
103
OLDNEW
« no previous file with comments | « build/android/process_resources.py ('k') | build/android/strip_library_for_apk.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698