Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1347273002: RELAND of Cross-repo recipe package system. (Closed)

Created:
5 years, 3 months ago by luqui
Modified:
5 years, 3 months ago
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org, stip+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build@master
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

RELAND of Cross-repo recipe package system. This rolls the package system created in https://codereview.chromium.org/1344583003/ into tools/build, moving core modules to the engine. See in particular the new entry point scripts/slave/recipes.py and the recipes configuration infra/config/recipes.cfg. Internal changes: https://chromereviews.googleplex.com/227207013/ TBR for uniform chromium_tests changes. R=iannucci@chromium.org TBR=phajdan.jr@chromium.org BUG=459840 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=296733

Patch Set 1 #

Patch Set 2 : Here's how it got fixed #

Total comments: 1

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+357 lines, -10390 lines) Patch
M .gitignore View 1 chunk +2 lines, -0 lines 0 comments Download
M PRESUBMIT.py View 1 chunk +1 line, -0 lines 0 comments Download
M infra/config/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download
A infra/config/recipes.cfg View 1 2 1 chunk +9 lines, -0 lines 0 comments Download
M scripts/slave/annotated_run.py View 1 2 3 chunks +27 lines, -6 lines 0 comments Download
M scripts/slave/bot_update.py View 3 chunks +24 lines, -3 lines 0 comments Download
M scripts/slave/recipe_modules/chromium_android/api.py View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipe_modules/chromium_android/example.py View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipe_modules/chromium_tests/__init__.py View 1 chunk +0 lines, -1 line 0 comments Download
M scripts/slave/recipe_modules/chromium_tests/api.py View 4 chunks +22 lines, -19 lines 0 comments Download
M scripts/slave/recipe_modules/chromium_tests/builders.py View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipe_modules/cronet/api.py View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipe_modules/cronet/example.py View 1 chunk +1 line, -1 line 0 comments Download
D scripts/slave/recipe_modules/example/__init__.py View 1 chunk +0 lines, -3 lines 0 comments Download
D scripts/slave/recipe_modules/example/api.py View 1 chunk +0 lines, -19 lines 0 comments Download
M scripts/slave/recipe_modules/file/__init__.py View 1 chunk +5 lines, -5 lines 0 comments Download
M scripts/slave/recipe_modules/file/example.py View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipe_modules/file/test_api.py View 1 chunk +0 lines, -26 lines 0 comments Download
M scripts/slave/recipe_modules/gatekeeper/test_api.py View 1 chunk +0 lines, -6 lines 0 comments Download
D scripts/slave/recipe_modules/generator_script/__init__.py View 1 chunk +0 lines, -6 lines 0 comments Download
D scripts/slave/recipe_modules/generator_script/api.py View 1 chunk +0 lines, -84 lines 0 comments Download
D scripts/slave/recipe_modules/generator_script/example.py View 1 chunk +0 lines, -67 lines 0 comments Download
D scripts/slave/recipe_modules/generator_script/example.expected/always_run.json View 1 chunk +0 lines, -77 lines 0 comments Download
D scripts/slave/recipe_modules/generator_script/example.expected/basic.json View 1 chunk +0 lines, -30 lines 0 comments Download
D scripts/slave/recipe_modules/generator_script/example.expected/basic_python.json View 1 chunk +0 lines, -35 lines 0 comments Download
D scripts/slave/recipe_modules/generator_script/example.expected/presentation.json View 1 chunk +0 lines, -38 lines 0 comments Download
D scripts/slave/recipe_modules/generator_script/test_api.py View 1 chunk +0 lines, -9 lines 0 comments Download
M scripts/slave/recipe_modules/git/__init__.py View 1 chunk +0 lines, -1 line 0 comments Download
M scripts/slave/recipe_modules/git/api.py View 2 chunks +2 lines, -1 line 0 comments Download
M scripts/slave/recipe_modules/gpu/api.py View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipe_modules/isolate/resources/compare_build_artifacts.py View 1 chunk +1 line, -1 line 0 comments Download
D scripts/slave/recipe_modules/itertools/__init__.py View 0 chunks +-1 lines, --1 lines 0 comments Download
D scripts/slave/recipe_modules/itertools/api.py View 1 chunk +0 lines, -11 lines 0 comments Download
D scripts/slave/recipe_modules/json/__init__.py View 1 chunk +0 lines, -5 lines 0 comments Download
D scripts/slave/recipe_modules/json/api.py View 1 chunk +0 lines, -122 lines 0 comments Download
D scripts/slave/recipe_modules/json/example.py View 1 chunk +0 lines, -49 lines 0 comments Download
D scripts/slave/recipe_modules/json/example.expected/basic.json View 1 chunk +0 lines, -63 lines 0 comments Download
D scripts/slave/recipe_modules/json/test_api.py View 1 chunk +0 lines, -15 lines 0 comments Download
D scripts/slave/recipe_modules/math_utils/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
D scripts/slave/recipe_modules/math_utils/__init__.py View 0 chunks +-1 lines, --1 lines 0 comments Download
D scripts/slave/recipe_modules/math_utils/api.py View 1 chunk +0 lines, -357 lines 0 comments Download
D scripts/slave/recipe_modules/path/__init__.py View 1 chunk +0 lines, -3 lines 0 comments Download
D scripts/slave/recipe_modules/path/api.py View 1 chunk +0 lines, -238 lines 0 comments Download
D scripts/slave/recipe_modules/path/config.py View 1 chunk +0 lines, -47 lines 0 comments Download
D scripts/slave/recipe_modules/path/example.py View 1 chunk +0 lines, -26 lines 0 comments Download
D scripts/slave/recipe_modules/path/example.expected/linux.json View 1 chunk +0 lines, -18 lines 0 comments Download
D scripts/slave/recipe_modules/path/example.expected/mac.json View 1 chunk +0 lines, -18 lines 0 comments Download
D scripts/slave/recipe_modules/path/example.expected/win.json View 1 chunk +0 lines, -18 lines 0 comments Download
D scripts/slave/recipe_modules/path/test_api.py View 1 chunk +0 lines, -12 lines 0 comments Download
D scripts/slave/recipe_modules/platform/__init__.py View 0 chunks +-1 lines, --1 lines 0 comments Download
D scripts/slave/recipe_modules/platform/api.py View 1 chunk +0 lines, -92 lines 0 comments Download
D scripts/slave/recipe_modules/platform/test_api.py View 1 chunk +0 lines, -18 lines 0 comments Download
D scripts/slave/recipe_modules/properties/__init__.py View 0 chunks +-1 lines, --1 lines 0 comments Download
D scripts/slave/recipe_modules/properties/api.py View 1 chunk +0 lines, -48 lines 0 comments Download
D scripts/slave/recipe_modules/properties/example.py View 1 chunk +0 lines, -30 lines 0 comments Download
D scripts/slave/recipe_modules/properties/example.expected/basic.json View 1 chunk +0 lines, -18 lines 0 comments Download
D scripts/slave/recipe_modules/properties/example.expected/dicts.json View 1 chunk +0 lines, -18 lines 0 comments Download
D scripts/slave/recipe_modules/properties/example.expected/lists.json View 1 chunk +0 lines, -18 lines 0 comments Download
D scripts/slave/recipe_modules/properties/test_api.py View 1 chunk +0 lines, -71 lines 0 comments Download
D scripts/slave/recipe_modules/python/__init__.py View 1 chunk +0 lines, -4 lines 0 comments Download
D scripts/slave/recipe_modules/python/api.py View 1 chunk +0 lines, -55 lines 0 comments Download
D scripts/slave/recipe_modules/python/example.py View 1 chunk +0 lines, -27 lines 0 comments Download
D scripts/slave/recipe_modules/python/example.expected/basic.json View 1 chunk +0 lines, -29 lines 0 comments Download
D scripts/slave/recipe_modules/raw_io/__init__.py View 1 chunk +0 lines, -1 line 0 comments Download
D scripts/slave/recipe_modules/raw_io/api.py View 1 chunk +0 lines, -159 lines 0 comments Download
D scripts/slave/recipe_modules/raw_io/example.py View 1 chunk +0 lines, -66 lines 0 comments Download
D scripts/slave/recipe_modules/raw_io/example.expected/basic.json View 1 chunk +0 lines, -66 lines 0 comments Download
D scripts/slave/recipe_modules/raw_io/test_api.py View 1 chunk +0 lines, -21 lines 0 comments Download
M scripts/slave/recipe_modules/skia/resources/run_binary_size_analysis.py View 1 chunk +1 line, -1 line 0 comments Download
D scripts/slave/recipe_modules/step/__init__.py View 1 chunk +0 lines, -3 lines 0 comments Download
D scripts/slave/recipe_modules/step/api.py View 1 chunk +0 lines, -150 lines 0 comments Download
D scripts/slave/recipe_modules/step/config.py View 1 chunk +0 lines, -58 lines 0 comments Download
D scripts/slave/recipe_modules/step/example.py View 1 chunk +0 lines, -115 lines 0 comments Download
D scripts/slave/recipe_modules/step/example.expected/basic.json View 1 chunk +0 lines, -114 lines 0 comments Download
D scripts/slave/recipe_modules/step/example.expected/defer_results.json View 1 chunk +0 lines, -95 lines 0 comments Download
D scripts/slave/recipe_modules/step/example.expected/exceptional.json View 1 chunk +0 lines, -79 lines 0 comments Download
D scripts/slave/recipe_modules/step/example.expected/infra_failure.json View 1 chunk +0 lines, -118 lines 0 comments Download
D scripts/slave/recipe_modules/step/example.expected/invalid_access.json View 1 chunk +0 lines, -124 lines 0 comments Download
M scripts/slave/recipe_modules/swarming/api.py View 1 chunk +1 line, -1 line 0 comments Download
D scripts/slave/recipe_modules/time/__init__.py View 0 chunks +-1 lines, --1 lines 0 comments Download
D scripts/slave/recipe_modules/time/api.py View 1 chunk +0 lines, -33 lines 0 comments Download
D scripts/slave/recipe_modules/time/example.py View 1 chunk +0 lines, -18 lines 0 comments Download
D scripts/slave/recipe_modules/time/example.expected/defaults.json View 1 chunk +0 lines, -10 lines 0 comments Download
D scripts/slave/recipe_modules/time/example.expected/seed_and_step.json View 1 chunk +0 lines, -10 lines 0 comments Download
D scripts/slave/recipe_modules/time/test_api.py View 1 chunk +0 lines, -16 lines 0 comments Download
D scripts/slave/recipe_modules/uuid/__init__.py View 0 chunks +-1 lines, --1 lines 0 comments Download
D scripts/slave/recipe_modules/uuid/api.py View 1 chunk +0 lines, -16 lines 0 comments Download
D scripts/slave/recipe_modules/uuid/example.py View 1 chunk +0 lines, -17 lines 0 comments Download
D scripts/slave/recipe_modules/uuid/example.expected/basic.json View 1 chunk +0 lines, -10 lines 0 comments Download
M scripts/slave/recipe_modules/v8/api.py View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipe_modules/v8/builders.py View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipe_modules/webrtc/api.py View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipe_modules/webrtc/builders.py View 1 2 1 chunk +1 line, -1 line 0 comments Download
D scripts/slave/recipe_universe.py View 1 chunk +0 lines, -27 lines 0 comments Download
A scripts/slave/recipes.py View 2 1 chunk +135 lines, -0 lines 0 comments Download
M scripts/slave/recipes/android/appurify.py View 2 chunks +1 line, -2 lines 0 comments Download
M scripts/slave/recipes/android/builder.py View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/android/perf.py View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/android_webview_aosp_perf.py View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/android_webview_shell_tests.py View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.py View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/blink_downstream.py View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/blink_trybot.py View 1 2 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/chromium.py View 3 chunks +18 lines, -1 line 0 comments Download
M scripts/slave/recipes/chromium_codesearch.py View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/chromium_gn.py View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/chromium_gn_upload.py View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/chromium_isolate.py View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/chromium_mojo.py View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/chromium_pgo.py View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/chromium_trybot.py View 3 chunks +9 lines, -2 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot_legacy.py View 4 chunks +5 lines, -4 lines 0 comments Download
M scripts/slave/recipes/cronet.py View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/dart/dartium_perf.py View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/gatekeeper.py View 2 chunks +0 lines, -14 lines 0 comments Download
D scripts/slave/recipes/gatekeeper.expected/real.json View 1 2 1 chunk +0 lines, -389 lines 0 comments Download
M scripts/slave/recipes/legion/legion.py View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/libvpx/android_unittests.py View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/libyuv/libyuv.py View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/ozone_ecs.py View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/swarming/deterministic_build.py View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/syzygy/continuous.py View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/v8/auto_roll_v8_deps.py View 1 chunk +1 line, -1 line 0 comments Download
A scripts/slave/unittests/annotated_run_test.py View 2 1 chunk +24 lines, -0 lines 0 comments Download
M scripts/slave/unittests/recipe_lint_test.py View 2 chunks +9 lines, -7 lines 0 comments Download
M scripts/slave/unittests/recipe_simulation_test.py View 1 chunk +14 lines, -4 lines 0 comments Download
D scripts/tools/show_me_the_modules.py View 1 chunk +0 lines, -124 lines 0 comments Download
D scripts/tools/unittests/show_me_the_modules_test.py View 1 chunk +0 lines, -20 lines 0 comments Download
M tests/masters_recipes_test.py View 5 chunks +22 lines, -12 lines 0 comments Download
D third_party/infra/README View 1 chunk +0 lines, -3 lines 0 comments Download
D third_party/infra/__init__.py View 0 chunks +-1 lines, --1 lines 0 comments Download
D third_party/infra/libs/__init__.py View 0 chunks +-1 lines, --1 lines 0 comments Download
D third_party/infra/libs/infra_types/__init__.py View 1 chunk +0 lines, -7 lines 0 comments Download
D third_party/infra/libs/infra_types/infra_types.py View 1 chunk +0 lines, -83 lines 0 comments Download
D third_party/infra/libs/infra_types/test/__init__.py View 0 chunks +-1 lines, --1 lines 0 comments Download
D third_party/infra/libs/infra_types/test/infra_types_test.py View 1 chunk +0 lines, -85 lines 0 comments Download
D third_party/recipe_engine/README.md View 1 chunk +0 lines, -10 lines 0 comments Download
D third_party/recipe_engine/__init__.py View 0 chunks +-1 lines, --1 lines 0 comments Download
D third_party/recipe_engine/config.py View 1 chunk +0 lines, -736 lines 0 comments Download
D third_party/recipe_engine/config_types.py View 1 chunk +0 lines, -164 lines 0 comments Download
D third_party/recipe_engine/doc/user_guide.md View 1 chunk +0 lines, -625 lines 0 comments Download
D third_party/recipe_engine/expect_tests/__init__.py View 1 chunk +0 lines, -9 lines 0 comments Download
D third_party/recipe_engine/expect_tests/cover.py View 1 chunk +0 lines, -85 lines 0 comments Download
D third_party/recipe_engine/expect_tests/handle_debug.py View 1 chunk +0 lines, -42 lines 0 comments Download
D third_party/recipe_engine/expect_tests/handle_list.py View 1 chunk +0 lines, -33 lines 0 comments Download
D third_party/recipe_engine/expect_tests/handle_test.py View 1 chunk +0 lines, -153 lines 0 comments Download
D third_party/recipe_engine/expect_tests/handle_train.py View 1 chunk +0 lines, -148 lines 0 comments Download
D third_party/recipe_engine/expect_tests/main.py View 1 chunk +0 lines, -163 lines 0 comments Download
D third_party/recipe_engine/expect_tests/pipeline.py View 1 chunk +0 lines, -248 lines 0 comments Download
D third_party/recipe_engine/expect_tests/serialize.py View 1 chunk +0 lines, -127 lines 0 comments Download
D third_party/recipe_engine/expect_tests/type_definitions.py View 1 chunk +0 lines, -433 lines 0 comments Download
D third_party/recipe_engine/expect_tests/unittest_helper.py View 1 chunk +0 lines, -94 lines 0 comments Download
D third_party/recipe_engine/expect_tests/util.py View 1 chunk +0 lines, -24 lines 0 comments Download
D third_party/recipe_engine/field_composer.py View 1 chunk +0 lines, -86 lines 0 comments Download
D third_party/recipe_engine/lint_test.py View 1 chunk +0 lines, -70 lines 0 comments Download
D third_party/recipe_engine/loader.py View 1 chunk +0 lines, -460 lines 0 comments Download
D third_party/recipe_engine/main.py View 1 chunk +0 lines, -939 lines 0 comments Download
D third_party/recipe_engine/recipe_api.py View 1 chunk +0 lines, -525 lines 0 comments Download
D third_party/recipe_engine/recipe_test_api.py View 1 chunk +0 lines, -462 lines 0 comments Download
D third_party/recipe_engine/simulation_test.py View 1 chunk +0 lines, -98 lines 0 comments Download
D third_party/recipe_engine/third_party/__init__.py View 0 chunks +-1 lines, --1 lines 0 comments Download
D third_party/recipe_engine/third_party/annotator.py View 1 chunk +0 lines, -348 lines 0 comments Download
D third_party/recipe_engine/unittests/field_composer_test.py View 1 chunk +0 lines, -82 lines 0 comments Download
D third_party/recipe_engine/unittests/properties_test.py View 1 chunk +0 lines, -102 lines 0 comments Download
D third_party/recipe_engine/util.py View 1 chunk +0 lines, -148 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
luqui
ptal
5 years, 3 months ago (2015-09-16 22:22:42 UTC) #1
iannucci
lgtm https://chromiumcodereview.appspot.com/1347273002/diff/20001/scripts/slave/recipes/annotated_run_test.py File scripts/slave/recipes/annotated_run_test.py (right): https://chromiumcodereview.appspot.com/1347273002/diff/20001/scripts/slave/recipes/annotated_run_test.py#newcode18 scripts/slave/recipes/annotated_run_test.py:18: 'dict_prop': Property(), list_prop!
5 years, 3 months ago (2015-09-16 22:26:49 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1347273002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1347273002/20001
5 years, 3 months ago (2015-09-16 22:37:00 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1347273002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1347273002/20001
5 years, 3 months ago (2015-09-16 22:39:09 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 3 months ago (2015-09-16 23:01:12 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1347273002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1347273002/40001
5 years, 3 months ago (2015-09-17 14:15:47 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:40001) as http://src.chromium.org/viewvc/chrome?view=rev&revision=296733
5 years, 3 months ago (2015-09-17 14:20:21 UTC) #13
luqui
5 years, 3 months ago (2015-09-17 14:52:30 UTC) #14
Message was sent while issue was closed. 
A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/1356603003/ by luqui@chromium.org.

The reason for reverting is: Rebase undid some changes.

Powered by Google App Engine
This is Rietveld 408576698