New network error pages: Update format of suggestions.

New network error pages:  Update format of suggestions.
In particular, split them into header / body format and
update their appearance a little, removing bold menu item
names.

BUG=174194
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=193004

[mmenke, 2013-04-05 11:33:25]

[eroman]:  Ping!

[ericroman, 2013-04-06 00:07:14]

Note that I am not an owner for these directories, so my review will be
non-authoritative. WIll common shortly though!

[ericroman, 2013-04-06 00:22:08]

lgtm

https://codereview.chromium.org/13471007/diff/15001/chrome/app/chromium_strin...
File chrome/app/chromium_strings.grd (right):

https://codereview.chromium.org/13471007/diff/15001/chrome/app/chromium_strin...
chrome/app/chromium_strings.grd:922: Select the current network twice
What does selecting twice mean?

https://codereview.chromium.org/13471007/diff/15001/chrome/common/localized_e...
File chrome/common/localized_error.cc (right):

https://codereview.chromium.org/13471007/diff/15001/chrome/common/localized_e...
chrome/common/localized_error.cc:546: suggest_dns_config->SetString("header",
I hope you tested these, because verifying correctness of his patch from
codereview is not  very easy :)

https://codereview.chromium.org/13471007/diff/15001/chrome/common/localized_e...
chrome/common/localized_error.cc:652: learn_more_url =
GURL(kRedirectLoopLearnMoreUrl);
nit: merge this onto previous line

[mmenke, 2013-04-06 01:26:25]

On 2013/04/06 00:07:14, ericroman wrote:
> Note that I am not an owner for these directories, so my review will be
> non-authoritative. WIll common shortly though!

I know you're not, but only top level owners own it, and figure they have enough
load that it's best to have someone else take a look first, and you're the only
network stack person I know who does a lot of JS.

[mmenke, 2013-04-08 15:35:46]

https://codereview.chromium.org/13471007/diff/15001/chrome/app/chromium_strin...
File chrome/app/chromium_strings.grd (right):

https://codereview.chromium.org/13471007/diff/15001/chrome/app/chromium_strin...
chrome/app/chromium_strings.grd:922: Select the current network twice
On 2013/04/06 00:22:08, ericroman wrote:
> What does selecting twice mean?

Should be "click twice".  Decided to move this change to  another CL, for
sanity's sake.

https://codereview.chromium.org/13471007/diff/15001/chrome/common/localized_e...
File chrome/common/localized_error.cc (right):

https://codereview.chromium.org/13471007/diff/15001/chrome/common/localized_e...
chrome/common/localized_error.cc:546: suggest_dns_config->SetString("header",
On 2013/04/06 00:22:08, ericroman wrote:
> I hope you tested these, because verifying correctness of his patch from
> codereview is not  very easy :)

Yea, I've tested all of these.  I set the suggestions to "-1", to see them all
for the current platform.

https://codereview.chromium.org/13471007/diff/15001/chrome/common/localized_e...
chrome/common/localized_error.cc:652: learn_more_url =
GURL(kRedirectLoopLearnMoreUrl);
On 2013/04/06 00:22:08, ericroman wrote:
> nit: merge this onto previous line

Oops...this was a line for debugging.  Removed.

[mmenke, 2013-04-08 15:39:14]

[+thakis]:  Please review the changes to localized_error.cc and neterror.html. 
Thanks!

https://codereview.chromium.org/13471007/diff/37003/chrome/common/localized_e...
File chrome/common/localized_error.cc (left):

https://codereview.chromium.org/13471007/diff/37003/chrome/common/localized_e...
chrome/common/localized_error.cc:53: SUGGEST_HOSTNAME              = 1 << 1,
This wasn't being used anywhere.

[Nico, 2013-04-09 00:36:30]

lgtm

[commit-bot: I haz the power, 2013-04-09 00:59:53]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mmenke@chromium.org/13471007/47001

[commit-bot: I haz the power, 2013-04-09 04:37:11]

Change committed as 193004