Change the format of reduce_debugline.py.

Change the format of reduce_debugline.py.

This script was added in http://crrev.com/192004 at first.

BUG=225343
NOTRY=true

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=193001

[Dai Mikurube (NOT FULLTIME), 2013-04-08 08:42:37]

Hi,

Could you take a look at this change?  It changes the output format of
reduce_debugline.py.

[peria, 2013-04-08 10:09:35]

https://codereview.chromium.org/13470029/diff/5001/tools/find_runtime_symbols...
File tools/find_runtime_symbols/reduce_debugline.py (right):

https://codereview.chromium.org/13470029/diff/5001/tools/find_runtime_symbols...
tools/find_runtime_symbols/reduce_debugline.py:47: if not prev_filename or
prev_filename != curr_filename:
Isn't "prev_filename != curr_filename" enough, if we initialize |prev_filename|
with an empty string?

[Dai Mikurube (NOT FULLTIME), 2013-04-08 10:53:16]

Thanks!

https://codereview.chromium.org/13470029/diff/5001/tools/find_runtime_symbols...
File tools/find_runtime_symbols/reduce_debugline.py (right):

https://codereview.chromium.org/13470029/diff/5001/tools/find_runtime_symbols...
tools/find_runtime_symbols/reduce_debugline.py:47: if not prev_filename or
prev_filename != curr_filename:
On 2013/04/08 10:09:35, peria wrote:
> Isn't "prev_filename != curr_filename" enough, if we initialize
|prev_filename|
> with an empty string?

Done.

[peria, 2013-04-09 02:27:37]

lgtm

[M-A Ruel, 2013-04-09 03:09:04]

lgtm

https://codereview.chromium.org/13470029/diff/10001/tools/find_runtime_symbol...
File tools/find_runtime_symbols/reduce_debugline.py (right):

https://codereview.chromium.org/13470029/diff/10001/tools/find_runtime_symbol...
tools/find_runtime_symbols/reduce_debugline.py:45: for address in
sorted(starting_dict.keys()):
for address in sorted(starting_dict):

https://codereview.chromium.org/13470029/diff/10001/tools/find_runtime_symbol...
tools/find_runtime_symbols/reduce_debugline.py:59: bits64 = True if
starting_list[-1][0] > 0xffffffff else False
bits64 = (starting_list[-1][0] > 0xffffffff)

https://codereview.chromium.org/13470029/diff/10001/tools/find_runtime_symbol...
File tools/find_runtime_symbols/tests/reduce_debugline_test.py (right):

https://codereview.chromium.org/13470029/diff/10001/tools/find_runtime_symbol...
tools/find_runtime_symbols/tests/reduce_debugline_test.py:53: (0xa41710,
'../../base/logging.h')
keep a comma on the last items of a list, it make adding or removing items
easier.

[Dai Mikurube (NOT FULLTIME), 2013-04-09 04:15:58]

Thank you!  Committing...

https://codereview.chromium.org/13470029/diff/10001/tools/find_runtime_symbol...
File tools/find_runtime_symbols/reduce_debugline.py (right):

https://codereview.chromium.org/13470029/diff/10001/tools/find_runtime_symbol...
tools/find_runtime_symbols/reduce_debugline.py:45: for address in
sorted(starting_dict.keys()):
On 2013/04/09 03:09:04, Marc-Antoine Ruel wrote:
> for address in sorted(starting_dict):

Done.

https://codereview.chromium.org/13470029/diff/10001/tools/find_runtime_symbol...
tools/find_runtime_symbols/reduce_debugline.py:59: bits64 = True if
starting_list[-1][0] > 0xffffffff else False
On 2013/04/09 03:09:04, Marc-Antoine Ruel wrote:
> bits64 = (starting_list[-1][0] > 0xffffffff)

Done.

https://codereview.chromium.org/13470029/diff/10001/tools/find_runtime_symbol...
File tools/find_runtime_symbols/tests/reduce_debugline_test.py (right):

https://codereview.chromium.org/13470029/diff/10001/tools/find_runtime_symbol...
tools/find_runtime_symbols/tests/reduce_debugline_test.py:53: (0xa41710,
'../../base/logging.h')
On 2013/04/09 03:09:04, Marc-Antoine Ruel wrote:
> keep a comma on the last items of a list, it make adding or removing items
> easier.

Done.

[commit-bot: I haz the power, 2013-04-09 04:16:32]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dmikurube@chromium.org/13470029/20001

[commit-bot: I haz the power, 2013-04-09 04:26:55]

Change committed as 193001