Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Unified Diff: tools/find_runtime_symbols/prepare_symbol_info.py

Issue 13470029: Change the format of reduce_debugline.py. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: addressed the comments Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/find_runtime_symbols/reduce_debugline.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/find_runtime_symbols/prepare_symbol_info.py
diff --git a/tools/find_runtime_symbols/prepare_symbol_info.py b/tools/find_runtime_symbols/prepare_symbol_info.py
index a7d6121ca3c9eca281d09130eefb117171625bd3..477c674e0297952ac16d30acb4f33303a1d9cddd 100755
--- a/tools/find_runtime_symbols/prepare_symbol_info.py
+++ b/tools/find_runtime_symbols/prepare_symbol_info.py
@@ -149,11 +149,11 @@ def prepare_symbol_info(maps_path,
output_dir_path, os.path.basename(entry.name), '.readelf-e')
if not readelf_e_filename:
continue
- readelf_reduced_debugline_filename = None
+ readelf_debug_decodedline_file = None
if use_source_file_name:
- readelf_reduced_debugline_filename = _dump_command_result(
- 'readelf -wLW %s | %s' % (entry.name, REDUCE_DEBUGLINE_PATH),
- output_dir_path, os.path.basename(entry.name), '.readelf-debugline')
+ readelf_debug_decodedline_file = _dump_command_result(
+ 'readelf -wL %s | %s' % (entry.name, REDUCE_DEBUGLINE_PATH),
+ output_dir_path, os.path.basename(entry.name), '.readelf-wL')
files[entry.name] = {}
files[entry.name]['nm'] = {
@@ -162,9 +162,9 @@ def prepare_symbol_info(maps_path,
'mangled': False}
files[entry.name]['readelf-e'] = {
'file': os.path.basename(readelf_e_filename)}
- if readelf_reduced_debugline_filename:
- files[entry.name]['readelf-reduced-debugline'] = {
- 'file': os.path.basename(readelf_reduced_debugline_filename)}
+ if readelf_debug_decodedline_file:
+ files[entry.name]['readelf-debug-decodedline-file'] = {
+ 'file': os.path.basename(readelf_debug_decodedline_file)}
with open(os.path.join(output_dir_path, 'files.json'), 'w') as f:
json.dump(files, f, indent=2, sort_keys=True)
« no previous file with comments | « no previous file | tools/find_runtime_symbols/reduce_debugline.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698