Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 13460012: Move IconsHandler from c/c/e/api/ to c/c/e (Closed)

Created:
7 years, 8 months ago by Devlin
Modified:
7 years, 8 months ago
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, dbeam+watch-options_chromium.org, jeremya+watch_chromium.org, sadrul, nkostylev+watch_chromium.org, feature-media-reviews_chromium.org, tfarina, ben+watch_chromium.org, jianli, Dmitry Titov, sail+watch_chromium.org, Aaron Boodman, rginda+watch_chromium.org, jennb, dcheng, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Move IconsHandler from c/c/e/api/ to c/c/e Move IconsHandler out of the API directory, and into the more general manifest_handlers/ directory. TBR=ben@chromium.org, tommi@chromium.org, mirandac@chromium.org, atwilson@chromium.org ben - ui, gypis tommi - media mirandac - profiles atwilson - background These are all mechanical/rename changes. BUG=159265 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=193838

Patch Set 1 : #

Patch Set 2 : Latest master for CQ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -457 lines) Patch
M chrome/browser/background/background_application_list_model.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/background/background_contents_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/extensions/file_browser_private_api.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/offline/offline_load_page.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/developer_private/developer_private_api.cc View 1 chunk +1 line, -1 line 0 comments Download
D chrome/browser/extensions/api/icons/icons_api.h View 1 chunk +0 lines, -37 lines 0 comments Download
D chrome/browser/extensions/api/icons/icons_api.cc View 1 chunk +0 lines, -30 lines 0 comments Download
M chrome/browser/extensions/api/management/management_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/app_icon_loader_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/chrome_manifest_parser.h View 1 chunk +1 line, -4 lines 0 comments Download
M chrome/browser/extensions/chrome_manifest_parser.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/browser/extensions/convert_web_app_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/convert_web_app_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/crx_installer.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_icon_image_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_icon_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_install_prompt.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_protocols.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_protocols_unittest.cc View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/extensions/extension_uninstall_dialog.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_web_ui.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/image_loader_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/tab_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/media/media_stream_capture_indicator.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/profiles/profile_dependency_manager.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/app_list/extension_app_item.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/app_list/search_builder.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/launcher/browser_launcher_item_controller.cc View 2 chunks +1 line, -3 lines 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_launcher_controller_per_app.cc View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_launcher_controller_per_browser.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/infobars/extension_infobar_controller.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/location_bar/action_box_menu_bubble_controller.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/location_bar/page_action_decoration.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/extensions/shell_window.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/action_box_button_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/create_application_shortcuts_dialog_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/infobars/extension_infobar_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/location_bar_view_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/script_bubble_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/panels/panel.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/action_box_menu.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/infobars/extension_infobar.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/location_bar/page_action_with_badge_view.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/ui/views/script_bubble_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/web_applications/web_app_ui.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/extensions/extension_icon_source.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/options/search_engine_manager_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_browser_extensions.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/chrome_common.gypi View 1 3 chunks +2 lines, -4 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 2 chunks +1 line, -1 line 0 comments Download
M chrome/common/extensions/api/extension_action/script_badge_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/api/extension_action/script_badge_manifest_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
D chrome/common/extensions/api/icons/icons_handler.h View 1 chunk +0 lines, -85 lines 0 comments Download
D chrome/common/extensions/api/icons/icons_handler.cc View 1 chunk +0 lines, -163 lines 0 comments Download
D chrome/common/extensions/api/icons/icons_manifest_unittest.cc View 1 chunk +0 lines, -63 lines 0 comments Download
M chrome/common/extensions/extension.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/extensions/extension.cc View 2 chunks +1 line, -3 lines 0 comments Download
M chrome/common/extensions/extension_file_util_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/common/extensions/manifest_handlers/icons_handler.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/common/extensions/manifest_handlers/icons_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/common/extensions/manifest_tests/extension_manifests_icons_unittest.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/common/extensions/manifest_tests/extension_manifests_initvalue_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/localized_error.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/extensions/resource_request_policy.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/utility/chrome_content_utility_client.cc View 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Devlin
7 years, 8 months ago (2013-04-10 20:28:20 UTC) #1
Yoyo Zhou
LGTM, but needs a BUG=
7 years, 8 months ago (2013-04-10 21:15:56 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rdevlin.cronin@chromium.org/13460012/22001
7 years, 8 months ago (2013-04-12 01:15:50 UTC) #3
commit-bot: I haz the power
Change committed as 193838
7 years, 8 months ago (2013-04-12 04:00:12 UTC) #4
Ben Goodger (Google)
7 years, 8 months ago (2013-04-16 16:14:57 UTC) #5
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698