Master configuration for the custom-tabs-client CQ

Master configuration for the custom-tabs-client CQ

master.tryserver.client.custom_tabs_client config

BUG=531547
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=296758

[pasko, 2015-09-15 18:39:26]

pasko@chromium.org changed reviewers:
+ stip@chromium.org

[pasko, 2015-09-15 18:42:42]

stip: PTaL.

Disclaimer: I have no idea what I am doing.

Presubmit fails with this change, so not for commit immediately, of course. I
assume some of the failured (see below) will go away when I decide what slave
name there would be. This depends on the bug: http://crbug.com/532110

Here are presubmit failures I am seeing:

FAILURE  The following master.cfg files did not load:

/hdd/34chrome-infra-build/build/masters/master.tryserver.client.custom_tabs_client
>  error while parsing
/hdd/34chrome-infra-build/build/masters/master.tryserver.client.custom_tabs_client/master.cfg:
>  Traceback (most recent call last):
>    File
"/hdd/34chrome-infra-build/build/scripts/slave/../common/master_cfg_utils.py",
line 105, in LoadConfig
>      localdict = ExecuteConfig(canonical_config)
>    File
"/hdd/34chrome-infra-build/build/scripts/slave/../common/master_cfg_utils.py",
line 80, in ExecuteConfig
>      exec f in localDict
>    File
"/hdd/34chrome-infra-build/build/masters/master.tryserver.client.custom_tabs_client/master.cfg",
line 26, in <module>
>      master_site_config.CustomTabsClientTryserver)
>    File "/hdd/34chrome-infra-build/build/scripts/master/master_gen.py", line
27, in PopulateBuildmasterConfig
>      _Populate(BuildmasterConfig, builders, active_master_cls)
>    File "/hdd/34chrome-infra-build/build/scripts/master/master_gen.py", line
46, in _Populate
>      c['builders'] = _ComputeBuilders(builders, m_annotator)
>    File "/hdd/34chrome-infra-build/build/scripts/master/master_gen.py", line
98, in _ComputeBuilders
>      scheduler_name = builder_data['scheduler']
>  KeyError: 'scheduler'
>
>  build error encountered! aborting build

Parsed 74 masters successfully, 1 failed, 1 skipped in 6s.


tests/masters_test.py (69.45s) failed
1 masters were not expected:
master.tryserver.client.custom_tabs_client
74 masters succeeded, 0 failed, 0 skipped in 69.3s.


tests/slaves_cfg_test.py (0.08s) failed
Traceback (most recent call last):
  File "tests/slaves_cfg_test.py", line 70, in <module>
    sys.exit(main())
  File "tests/slaves_cfg_test.py", line 37, in main
    include_internal=False)
  File "/hdd/34chrome-infra-build/build/scripts/common/chromium_utils.py", line
1292, in GetAllSlaves
    cur_slaves = GetSlavesFromMasterPath(master, fail_hard)
  File "/hdd/34chrome-infra-build/build/scripts/common/chromium_utils.py", line
1284, in GetSlavesFromMasterPath
    return GetSlavesFromBuildersFile(builders_path)
  File "/hdd/34chrome-infra-build/build/scripts/common/chromium_utils.py", line
1870, in GetSlavesFromBuildersFile
    return GetSlavesFromBuilders(builders)
  File "/hdd/34chrome-infra-build/build/scripts/common/chromium_utils.py", line
1888, in GetSlavesFromBuilders
    for slave in pool_data['slaves']:
KeyError: 'slaves'


Presubmit checks took 69.9s to calculate.

[ghost stip (do not use), 2015-09-15 19:42:26]

just need a few tweaks, I linked to a recommended example builders.pyl to copy
off of.

you may want the template directive at the top too, not sure

https://chromiumcodereview.appspot.com/1345803002/diff/1/masters/master.tryse...
File masters/master.tryserver.client.custom_tabs_client/builders.pyl (right):

https://chromiumcodereview.appspot.com/1345803002/diff/1/masters/master.tryse...
masters/master.tryserver.client.custom_tabs_client/builders.pyl:4: "recipe":
"custom_tabs_client",
you should add a scheduler here

see
https://chromium.googlesource.com/chromium/tools/build/+/master/masters/maste...

https://chromiumcodereview.appspot.com/1345803002/diff/1/masters/master.tryse...
masters/master.tryserver.client.custom_tabs_client/builders.pyl:21: },
"slaves": ["coolbot-a1"],

see
https://chromium.googlesource.com/chromium/tools/build/+/master/masters/maste...

[pasko, 2015-09-16 11:32:16]

PTAL, after the changes you suggested there is only one presubmit warning:
** Presubmit Warnings **
tests/masters_test.py (66.77s) failed
1 masters were not expected:
master.tryserver.client.custom_tabs_client
74 masters succeeded, 0 failed, 0 skipped in 66.6s.


what should I do to make it stop complaining?

https://chromiumcodereview.appspot.com/1345803002/diff/1/masters/master.tryse...
File masters/master.tryserver.client.custom_tabs_client/builders.pyl (right):

https://chromiumcodereview.appspot.com/1345803002/diff/1/masters/master.tryse...
masters/master.tryserver.client.custom_tabs_client/builders.pyl:4: "recipe":
"custom_tabs_client",
On 2015/09/15 19:42:26, stip wrote:
> you should add a scheduler here
> 
> see
>
https://chromium.googlesource.com/chromium/tools/build/+/master/masters/maste...

Trying. Added '"scheduler": None,' and '"schedulers": {},' because:
1. It is done this way in the master.tryserver.client.catapult config
2. The link you provided demonstrates only polling schedulers, which I think I
do not need for a trybot.

Maybe I would have to go through the trouble to configure buildbucket, but I
don't know at this point :(

https://chromiumcodereview.appspot.com/1345803002/diff/1/masters/master.tryse...
masters/master.tryserver.client.custom_tabs_client/builders.pyl:21: },
On 2015/09/15 19:42:26, stip wrote:
> "slaves": ["coolbot-a1"],
> 
> see
>
https://chromium.googlesource.com/chromium/tools/build/+/master/masters/maste...

OK, I added '"slaves": ["unknown"]' because the slave name is not known yet
(should be revealed in crbug.com/532110).

[pasko, 2015-09-16 11:33:38]

Generally, should I wait for the slave to become available before submitting
this? Will it break anything if the slave name is "unknown"?

[ghost stip (do not use), 2015-09-16 18:54:33]

stip@chromium.org changed reviewers:
+ nodir@chromium.org

[ghost stip (do not use), 2015-09-16 18:54:33]

add it to
https://chromium.googlesource.com/chromium/tools/build/+/master/tests/masters...

you can commit with a fake bot name, it should be OK.

adding nodir@ for the buildbucket question

[pasko, 2015-09-17 11:15:19]

On 2015/09/16 18:54:33, stip wrote:
> add it to
>
https://chromium.googlesource.com/chromium/tools/build/+/master/tests/masters...

Done. It helps.
 
> you can commit with a fake bot name, it should be OK.
> 
> adding nodir@ for the buildbucket question

Thanks, PTAL

(the slave name is not known yet:
https://code.google.com/p/chromium/issues/detail?id=532110)

[nodir, 2015-09-17 16:38:09]

How to create a bucket? See
https://chromium.googlesource.com/infra/infra/+/HEAD/appengine/cr-buildbucket...

[nodir, 2015-09-17 16:40:24]

https://chromiumcodereview.appspot.com/1345803002/diff/40001/masters/master.t...
File masters/master.tryserver.client.custom_tabs_client/builders.pyl (right):

https://chromiumcodereview.appspot.com/1345803002/diff/40001/masters/master.t...
masters/master.tryserver.client.custom_tabs_client/builders.pyl:12: 
add

  buildbucket_bucket: "master.tryserver.client.custom_tabs_client",
  service_account_file: "service-account-chromium.json",

[nodir, 2015-09-17 17:55:33]

https://chromiumcodereview.appspot.com/1345803002/diff/40001/masters/master.t...
File masters/master.tryserver.client.custom_tabs_client/builders.pyl (right):

https://chromiumcodereview.appspot.com/1345803002/diff/40001/masters/master.t...
masters/master.tryserver.client.custom_tabs_client/builders.pyl:12: 
On 2015/09/17 16:40:24, nodir wrote:
> add
> 
>   buildbucket_bucket: "master.tryserver.client.custom_tabs_client",
>   service_account_file: "service-account-chromium.json",

correction: "service-account-chromium-tryserver.json",

[pasko, 2015-09-17 18:05:54]

... with the suggested buildbucket additions, PTAL

https://chromiumcodereview.appspot.com/1345803002/diff/40001/masters/master.t...
File masters/master.tryserver.client.custom_tabs_client/builders.pyl (right):

https://chromiumcodereview.appspot.com/1345803002/diff/40001/masters/master.t...
masters/master.tryserver.client.custom_tabs_client/builders.pyl:12: 
On 2015/09/17 17:55:33, nodir wrote:
> On 2015/09/17 16:40:24, nodir wrote:
> > add
> > 
> >   buildbucket_bucket: "master.tryserver.client.custom_tabs_client",
> >   service_account_file: "service-account-chromium.json",
> 
> correction: "service-account-chromium-tryserver.json",

Done.

[nodir, 2015-09-17 18:07:21]

lgtm

[ghost stip (do not use), 2015-09-17 18:22:19]

lgtm

[pasko, 2015-09-18 09:54:20]

The CQ bit was checked by pasko@chromium.org

[commit-bot: I haz the power, 2015-09-18 09:54:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1345803002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1345803002/60001

[commit-bot: I haz the power, 2015-09-18 09:57:39]

Committed patchset #4 (id:60001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=296758