Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(412)

Issue 1344593002: Remove redundant handling of the default_browser_setting_enabled policy. (Closed)

Created:
5 years, 3 months ago by grt (UTC plus 2)
Modified:
5 years, 3 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove redundant handling of the default_browser_setting_enabled policy. While the default browser infobar should be suppressed when policy is used to enforce defaultness, there is no need to handle the policy in the infobar as it is already fully handled in BrowserProcessImpl. BUG=531649 TEST=Verify that all settings of https://www.chromium.org/administrators/policy-list-3#DefaultBrowserSettingEnabled work properly. If the policy is set (either enabled or disabled), the default browser bar should not appear. On Windows 7, Chrome should become the default browser at startup when the policy is enabled. If the policy is unset and Chrome is not the default browser, the default browser infobar should appear. R=pastarmovj@chromium.org Committed: https://crrev.com/22a6f88626b2cf12e55e11eda3f1246313037483 Cr-Commit-Position: refs/heads/master@{#349889}

Patch Set 1 #

Patch Set 2 : cleanup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -19 lines) Patch
M chrome/browser/ui/startup/default_browser_prompt.cc View 1 1 chunk +10 lines, -19 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 14 (4 generated)
grt (UTC plus 2)
PTAL
5 years, 3 months ago (2015-09-14 16:32:50 UTC) #1
grt (UTC plus 2)
pkasting: could you take a look at this? thanks.
5 years, 3 months ago (2015-09-16 16:46:24 UTC) #3
Peter Kasting
LGTM on code change, I trust you (and the test directions) regarding whether this is ...
5 years, 3 months ago (2015-09-16 23:19:19 UTC) #4
grt (UTC plus 2)
On 2015/09/16 23:19:19, Peter Kasting wrote: > LGTM on code change, I trust you (and ...
5 years, 3 months ago (2015-09-19 01:34:47 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1344593002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1344593002/20001
5 years, 3 months ago (2015-09-19 01:35:49 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/106398)
5 years, 3 months ago (2015-09-19 02:17:19 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1344593002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1344593002/20001
5 years, 3 months ago (2015-09-20 22:44:33 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 3 months ago (2015-09-20 23:36:32 UTC) #12
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/22a6f88626b2cf12e55e11eda3f1246313037483 Cr-Commit-Position: refs/heads/master@{#349889}
5 years, 3 months ago (2015-09-20 23:37:08 UTC) #13
pastarmovj
5 years, 3 months ago (2015-09-24 14:14:58 UTC) #14
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698