Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Issue 1338423004: Use the DefaultBrowserWorker to check/set Chrome as the default browser. (Closed)

Created:
5 years, 3 months ago by grt (UTC plus 2)
Modified:
5 years, 2 months ago
Reviewers:
Peter Kasting
CC:
chromium-reviews, gab
Base URL:
https://chromium.googlesource.com/chromium/src.git@defbrow
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use the DefaultBrowserWorker to check/set Chrome as the default browser. This is a cleanup CL. The worker takes care of the thread bouncing, simplifying the default browser prompt. This also makes the default browser prompt use the same codepath used elsewhere to check/set defaultness. BUG=531649 TEST=The default browser inforbar should work as before. Committed: https://crrev.com/9c8bb5ec3aea2ac69ec493aa2c237596e35b2341 Cr-Commit-Position: refs/heads/master@{#350390}

Patch Set 1 #

Total comments: 4

Patch Set 2 : pkasting comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+145 lines, -87 lines) Patch
M chrome/browser/ui/startup/default_browser_prompt.cc View 1 9 chunks +145 lines, -87 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 23 (10 generated)
grt (UTC plus 2)
Hi Gab. PTAL at this refactoring w/ no change in behavior. It switches the default ...
5 years, 3 months ago (2015-09-14 20:08:15 UTC) #2
grt (UTC plus 2)
PK: Could you take a look? Thanks.
5 years, 3 months ago (2015-09-21 15:26:55 UTC) #4
Peter Kasting
LGTM https://codereview.chromium.org/1338423004/diff/1/chrome/browser/ui/startup/default_browser_prompt.cc File chrome/browser/ui/startup/default_browser_prompt.cc (right): https://codereview.chromium.org/1338423004/diff/1/chrome/browser/ui/startup/default_browser_prompt.cc#newcode47 chrome/browser/ui/startup/default_browser_prompt.cc:47: void SetDefaultWebClientUIState( Nit: I would make these private ...
5 years, 3 months ago (2015-09-22 21:17:25 UTC) #5
grt (UTC plus 2)
Thanks. https://codereview.chromium.org/1338423004/diff/1/chrome/browser/ui/startup/default_browser_prompt.cc File chrome/browser/ui/startup/default_browser_prompt.cc (right): https://codereview.chromium.org/1338423004/diff/1/chrome/browser/ui/startup/default_browser_prompt.cc#newcode47 chrome/browser/ui/startup/default_browser_prompt.cc:47: void SetDefaultWebClientUIState( On 2015/09/22 21:17:25, Peter Kasting wrote: ...
5 years, 2 months ago (2015-09-23 13:57:49 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1338423004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1338423004/20001
5 years, 2 months ago (2015-09-23 13:58:36 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/116815)
5 years, 2 months ago (2015-09-23 14:10:01 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1338423004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1338423004/20001
5 years, 2 months ago (2015-09-23 16:46:35 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/56522)
5 years, 2 months ago (2015-09-23 17:26:08 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1338423004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1338423004/20001
5 years, 2 months ago (2015-09-23 20:07:44 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/107828)
5 years, 2 months ago (2015-09-23 21:06:04 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1338423004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1338423004/20001
5 years, 2 months ago (2015-09-23 22:22:38 UTC) #21
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-09-23 23:41:26 UTC) #22
commit-bot: I haz the power
5 years, 2 months ago (2015-09-23 23:42:17 UTC) #23
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/9c8bb5ec3aea2ac69ec493aa2c237596e35b2341
Cr-Commit-Position: refs/heads/master@{#350390}

Powered by Google App Engine
This is Rietveld 408576698