|
|
Created:
5 years, 3 months ago by grt (UTC plus 2) Modified:
5 years, 2 months ago Reviewers:
Peter Kasting CC:
chromium-reviews, gab Base URL:
https://chromium.googlesource.com/chromium/src.git@defbrow Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionUse the DefaultBrowserWorker to check/set Chrome as the default browser.
This is a cleanup CL. The worker takes care of the thread bouncing,
simplifying the default browser prompt. This also makes the default
browser prompt use the same codepath used elsewhere to check/set
defaultness.
BUG=531649
TEST=The default browser inforbar should work as before.
Committed: https://crrev.com/9c8bb5ec3aea2ac69ec493aa2c237596e35b2341
Cr-Commit-Position: refs/heads/master@{#350390}
Patch Set 1 #
Total comments: 4
Patch Set 2 : pkasting comments #
Depends on Patchset: Messages
Total messages: 23 (10 generated)
grt@chromium.org changed reviewers: + gab@chromium.org
Hi Gab. PTAL at this refactoring w/ no change in behavior. It switches the default browser prompt to using a DefaultBrowserWorker rather than doing its own thread bouncing so that it uses the same infrastructure and codepath as other things like the settings page. Thanks.
grt@chromium.org changed reviewers: + pkasting@chromium.org - gab@chromium.org
PK: Could you take a look? Thanks.
LGTM https://codereview.chromium.org/1338423004/diff/1/chrome/browser/ui/startup/d... File chrome/browser/ui/startup/default_browser_prompt.cc (right): https://codereview.chromium.org/1338423004/diff/1/chrome/browser/ui/startup/d... chrome/browser/ui/startup/default_browser_prompt.cc:47: void SetDefaultWebClientUIState( Nit: I would make these private if they aren't called directly by someone holding a SetDefaultBrowserObserver* (same with other classes below) https://codereview.chromium.org/1338423004/diff/1/chrome/browser/ui/startup/d... chrome/browser/ui/startup/default_browser_prompt.cc:221: ~CheckDefaultBrowserObserver() override; Nit: Blank line below this for consistency with the class you defined earlier
Thanks. https://codereview.chromium.org/1338423004/diff/1/chrome/browser/ui/startup/d... File chrome/browser/ui/startup/default_browser_prompt.cc (right): https://codereview.chromium.org/1338423004/diff/1/chrome/browser/ui/startup/d... chrome/browser/ui/startup/default_browser_prompt.cc:47: void SetDefaultWebClientUIState( On 2015/09/22 21:17:25, Peter Kasting wrote: > Nit: I would make these private if they aren't called directly by someone > holding a SetDefaultBrowserObserver* (same with other classes below) Done here and in CheckDefaultBrowserObserver. https://codereview.chromium.org/1338423004/diff/1/chrome/browser/ui/startup/d... chrome/browser/ui/startup/default_browser_prompt.cc:221: ~CheckDefaultBrowserObserver() override; On 2015/09/22 21:17:25, Peter Kasting wrote: > Nit: Blank line below this for consistency with the class you defined earlier Done.
The CQ bit was checked by grt@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from pkasting@chromium.org Link to the patchset: https://codereview.chromium.org/1338423004/#ps20001 (title: "pkasting comments")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1338423004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1338423004/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by grt@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1338423004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1338423004/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by grt@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1338423004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1338423004/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
The CQ bit was checked by grt@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1338423004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1338423004/20001
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/9c8bb5ec3aea2ac69ec493aa2c237596e35b2341 Cr-Commit-Position: refs/heads/master@{#350390} |