Issue 133693004: Add special case templates to handle Global/WindowEventHandlers

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 133693004: Add special case templates to handle Global/WindowEventHandlers (Closed)

Created:
6 years, 11 months ago by vsm

Modified:
6 years, 11 months ago

Reviewers:
blois

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Add special case templates to handle Global/WindowEventHandlers TBR=blois@google.com BUG=15954 Committed: https://code.google.com/p/dart/source/detail?r=31714

Patch Set 1 #

Patch Set 2 : Update whitelist #

Total comments: 1

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -19 lines)			Patch
M	sdk/lib/html/dart2js/html_dart2js.dart	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	sdk/lib/html/dartium/html_dartium.dart	View		5 chunks	+5 lines, -11 lines	0 comments	Download
M	tests/compiler/dart2js/analyze_api_test.dart	View	1	1 chunk	+0 lines, -4 lines	0 comments	Download
A +	tools/dom/templates/html/impl/impl_GlobalEventHandlers.darttemplate	View		1 chunk	+1 line, -1 line	1 comment	Download
A +	tools/dom/templates/html/impl/impl_WindowEventHandlers.darttemplate	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

vsm

Committed patchset #2 manually as r31714 (presubmit successful).

6 years, 11 months ago (2014-01-10 21:59:46 UTC) #2

blois

6 years, 11 months ago (2014-01-10 22:01:22 UTC) #3

Message was sent while issue was closed.

https://chromiumcodereview.appspot.com/133693004/diff/30001/tools/dom/templat...
File tools/dom/templates/html/impl/impl_GlobalEventHandlers.darttemplate
(right):

https://chromiumcodereview.appspot.com/133693004/diff/30001/tools/dom/templat...
tools/dom/templates/html/impl/impl_GlobalEventHandlers.darttemplate:8:
$(ANNOTATIONS)$(CLASS_MODIFIERS)class $CLASSNAME extends EventTarget$NATIVESPEC
{
Implements rather than extends?

Expand Messages | Collapse Messages