chrome/browser/browsing_data/browsing_data_remover.cc - Issue 13357004: Clear browsing data clears data for type kStorageTypeTemporary but not for kStorageTypeSyncable.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/browsing_data/browsing_data_remover.cc

Issue 13357004: Clear browsing data clears data for type kStorageTypeTemporary but not for kStorageTypeSyncable. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rebase again Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/browsing_data/browsing_data_quota_helper_unittest.cc ('k') | chrome/browser/browsing_data/mock_browsing_data_file_system_helper.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/browsing_data/browsing_data_remover.cc

diff --git a/chrome/browser/browsing_data/browsing_data_remover.cc b/chrome/browser/browsing_data/browsing_data_remover.cc

index 13e03989387a4d42de6a8bd4c504824212058947..58cae6cf3306a7b577c408e3fec4c89f2a556b92 100644

--- a/chrome/browser/browsing_data/browsing_data_remover.cc

+++ b/chrome/browser/browsing_data/browsing_data_remover.cc

@@ -883,6 +883,14 @@ void BrowsingDataRemover::ClearQuotaManagedDataOnIOThread() {

quota::kStorageTypeTemporary, delete_begin_,

base::Bind(&BrowsingDataRemover::OnGotQuotaManagedOrigins,

base::Unretained(this)));

+ // Do the same for syncable quota.

+ ++quota_managed_storage_types_to_delete_count_;

+ quota_manager_->GetOriginsModifiedSince(

+ quota::kStorageTypeSyncable, delete_begin_,

+ base::Bind(&BrowsingDataRemover::OnGotQuotaManagedOrigins,

+ base::Unretained(this)));

}

void BrowsingDataRemover::OnGotQuotaManagedOrigins(