Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(567)

Unified Diff: chrome/browser/browsing_data/browsing_data_quota_helper_unittest.cc

Issue 13357004: Clear browsing data clears data for type kStorageTypeTemporary but not for kStorageTypeSyncable. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase again Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/browsing_data/browsing_data_quota_helper_unittest.cc
diff --git a/chrome/browser/browsing_data/browsing_data_quota_helper_unittest.cc b/chrome/browser/browsing_data/browsing_data_quota_helper_unittest.cc
index b905a56925a2df38bfb1171e37262f7100ee4862..f4f4d331f27ac4c2a37a806e1ae4558c7dae5d74 100644
--- a/chrome/browser/browsing_data/browsing_data_quota_helper_unittest.cc
+++ b/chrome/browser/browsing_data/browsing_data_quota_helper_unittest.cc
@@ -142,6 +142,7 @@ TEST_F(BrowsingDataQuotaHelperTest, FetchData) {
{"http://example.com/", quota::kStorageTypeTemporary, 1},
{"https://example.com/", quota::kStorageTypeTemporary, 10},
{"http://example.com/", quota::kStorageTypePersistent, 100},
+ {"https://example.com/", quota::kStorageTypeSyncable, 1},
{"http://example2.com/", quota::kStorageTypeTemporary, 1000},
};
@@ -152,8 +153,8 @@ TEST_F(BrowsingDataQuotaHelperTest, FetchData) {
std::set<QuotaInfo> expected, actual;
actual.insert(quota_info().begin(), quota_info().end());
- expected.insert(QuotaInfo("example.com", 11, 100));
- expected.insert(QuotaInfo("example2.com", 1000, 0));
+ expected.insert(QuotaInfo("example.com", 11, 100, 1));
+ expected.insert(QuotaInfo("example2.com", 1000, 0, 0));
EXPECT_TRUE(expected == actual);
}
@@ -162,6 +163,7 @@ TEST_F(BrowsingDataQuotaHelperTest, IgnoreExtensionsAndDevTools) {
{"http://example.com/", quota::kStorageTypeTemporary, 1},
{"https://example.com/", quota::kStorageTypeTemporary, 10},
{"http://example.com/", quota::kStorageTypePersistent, 100},
+ {"https://example.com/", quota::kStorageTypeSyncable, 1},
{"http://example2.com/", quota::kStorageTypeTemporary, 1000},
{"chrome-extension://abcdefghijklmnopqrstuvwxyz/",
quota::kStorageTypeTemporary, 10000},
@@ -180,8 +182,8 @@ TEST_F(BrowsingDataQuotaHelperTest, IgnoreExtensionsAndDevTools) {
std::set<QuotaInfo> expected, actual;
actual.insert(quota_info().begin(), quota_info().end());
- expected.insert(QuotaInfo("example.com", 11, 100));
- expected.insert(QuotaInfo("example2.com", 1000, 0));
+ expected.insert(QuotaInfo("example.com", 11, 100, 1));
+ expected.insert(QuotaInfo("example2.com", 1000, 0, 0));
EXPECT_TRUE(expected == actual);
}
« no previous file with comments | « chrome/browser/browsing_data/browsing_data_quota_helper_impl.cc ('k') | chrome/browser/browsing_data/browsing_data_remover.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698