Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Unified Diff: content/public/browser/devtools_manager.h

Issue 13305002: Remove redundant DevToolsManager methods and clean up its clients. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/devtools/worker_devtools_manager.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/public/browser/devtools_manager.h
diff --git a/content/public/browser/devtools_manager.h b/content/public/browser/devtools_manager.h
index ae5df5a91dcffe0ee5c3902b73d36fd14502d2aa..84b9c9d8ca8a7d6f9e94eeacd1d2e3b7bf107ce6 100644
--- a/content/public/browser/devtools_manager.h
+++ b/content/public/browser/devtools_manager.h
@@ -34,26 +34,27 @@ class CONTENT_EXPORT DevToolsManager {
virtual bool DispatchOnInspectorBackend(DevToolsClientHost* from,
const std::string& message) = 0;
- // Closes all open developer tools windows.
+ // Routes devtools message from |from| agent host to corresponding
+ // DevToolsClientHost.
+ virtual void DispatchOnInspectorFrontend(DevToolsAgentHost* from,
pfeldman 2013/03/29 11:35:49 I don't think that anyone other than devtools agen
Vladislav Kaznacheev 2013/03/29 15:15:35 Moved to impl part. On 2013/03/29 11:35:49, pfeldm
+ const std::string& message) = 0;
+
+ // Disconnects all client hostst.
virtual void CloseAllClientHosts() = 0;
- // Returns client attached to the |agent_host| if there is one.
- virtual DevToolsClientHost* GetDevToolsClientHostFor(
- DevToolsAgentHost* agent_host) = 0;
+ // Returns true if there is a client attached to the |agent_host|.
+ virtual bool IsAttached(DevToolsAgentHost* agent_host) = 0;
// Returns agent that has |client_host| attachd to it if there is one.
virtual DevToolsAgentHost* GetDevToolsAgentHostFor(
DevToolsClientHost* client_host) = 0;
- // Registers new DevToolsClientHost for inspected |agent_host|. There must be
- // no other DevToolsClientHosts registered for the |agent_host| at the moment.
+ // Registers new DevToolsClientHost for inspected |agent_host|. If there is
+ // another DevToolsClientHost registered for the |agent_host| at the moment
+ // it is disconnected.
virtual void RegisterDevToolsClientHostFor(
DevToolsAgentHost* agent_host,
DevToolsClientHost* client_host) = 0;
- // Unregisters given |agent_host|. DevToolsManager will notify corresponding
- // client if one is attached.
- virtual void UnregisterDevToolsClientHostFor(
- DevToolsAgentHost* agent_host) = 0;
// This method will remove all references from the manager to the
// DevToolsClientHost and unregister all listeners related to the
« no previous file with comments | « content/browser/devtools/worker_devtools_manager.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698