Remove redundant DevToolsManager methods and clean up its clients.

content/public/browser/devtools_manager.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_PUBLIC_BROWSER_DEVTOOLS_MANAGER_H_
 #define CONTENT_PUBLIC_BROWSER_DEVTOOLS_MANAGER_H_
 
 #include <string>
 
 #include "content/common/content_export.h"
@@ skipping 16 matching lines @@
  public:
   static DevToolsManager* GetInstance();
 
   virtual ~DevToolsManager() {}
 
   // Routes devtools message from |from| client to corresponding
   // DevToolsAgentHost.
   virtual bool DispatchOnInspectorBackend(DevToolsClientHost* from,
                                           const std::string& message) = 0;
 
-  // Closes all open developer tools windows.
+  // Routes devtools message from |from| agent host to corresponding
+  // DevToolsClientHost.
+  virtual void DispatchOnInspectorFrontend(DevToolsAgentHost* from,

[pfeldman, 2013/03/29 11:35:49]

I don't think that anyone other than devtools agent should be able to dispatch
messages on agent's behalf.

[Vladislav Kaznacheev, 2013/03/29 15:15:35]

Moved to impl part.
On 2013/03/29 11:35:49, pfeldman wrote:

+                                           const std::string& message) = 0;
+
+  // Disconnects all client hostst.
   virtual void CloseAllClientHosts() = 0;
 
-  // Returns client attached to the |agent_host| if there is one.
-  virtual DevToolsClientHost* GetDevToolsClientHostFor(
-      DevToolsAgentHost* agent_host) = 0;
+  // Returns true if there is a client attached to the |agent_host|.
+  virtual bool IsAttached(DevToolsAgentHost* agent_host) = 0;
 
   // Returns agent that has |client_host| attachd to it if there is one.
   virtual DevToolsAgentHost* GetDevToolsAgentHostFor(
       DevToolsClientHost* client_host) = 0;
 
-  // Registers new DevToolsClientHost for inspected |agent_host|. There must be
-  // no other DevToolsClientHosts registered for the |agent_host| at the moment.
+  // Registers new DevToolsClientHost for inspected |agent_host|. If there is
+  // another DevToolsClientHost registered for the |agent_host| at the moment
+  // it is disconnected.
   virtual void RegisterDevToolsClientHostFor(
       DevToolsAgentHost* agent_host,
       DevToolsClientHost* client_host) = 0;
-  // Unregisters given |agent_host|. DevToolsManager will notify corresponding
-  // client if one is attached.
-  virtual void UnregisterDevToolsClientHostFor(
-      DevToolsAgentHost* agent_host) = 0;
 
   // This method will remove all references from the manager to the
   // DevToolsClientHost and unregister all listeners related to the
   // DevToolsClientHost. Called by closing client.
   virtual void ClientHostClosing(DevToolsClientHost* client_host) = 0;
 };
 
 }  // namespace content
 
 #endif  // CONTENT_PUBLIC_BROWSER_DEVTOOLS_MANAGER_H_