Make ErrorConsole catch errors from Extension WebContents Views

Make ErrorConsole catch errors from Extension WebContents Views

Allow ErrorConsole to catch errors from added html pages which are run in their
own view.  Test included.

BUG=21734
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=246252

[Yoyo Zhou, 2014-01-22 01:38:18]

LGTM with nits

https://chromiumcodereview.appspot.com/133003003/diff/30002/chrome/browser/ex...
File chrome/browser/extensions/error_console/error_console_browsertest.cc
(right):

https://chromiumcodereview.appspot.com/133003003/diff/30002/chrome/browser/ex...
chrome/browser/extensions/error_console/error_console_browsertest.cc:196:
ACTION_NEW_TAB,
I think this is ok, but in the future we might want to be able to navigate to an
arbitrary URL (i.e. rolling this and NAVIGATE together).

https://chromiumcodereview.appspot.com/133003003/diff/30002/chrome/test/data/...
File chrome/test/data/extensions/error_console/bad_extension_page/manifest.json
(right):

https://chromiumcodereview.appspot.com/133003003/diff/30002/chrome/test/data/...
chrome/test/data/extensions/error_console/bad_extension_page/manifest.json:3:
"description": "An extension which breaks when visiting the new tab page",
Perhaps "throws an error" instead of "breaks"?

[Devlin, 2014-01-22 01:58:09]

https://codereview.chromium.org/133003003/diff/30002/chrome/browser/extension...
File chrome/browser/extensions/error_console/error_console_browsertest.cc
(right):

https://codereview.chromium.org/133003003/diff/30002/chrome/browser/extension...
chrome/browser/extensions/error_console/error_console_browsertest.cc:196:
ACTION_NEW_TAB,
On 2014/01/22 01:38:19, Yoyo Zhou wrote:
> I think this is ok, but in the future we might want to be able to navigate to
an
> arbitrary URL (i.e. rolling this and NAVIGATE together).

Yeah, I was wondering the same thing.  I think, for now, we're okay, but if we
ever need to navigate to another specific URL (one other than the NTP, that is),
I'll be sure to combine them and clean it up.

https://codereview.chromium.org/133003003/diff/30002/chrome/test/data/extensi...
File chrome/test/data/extensions/error_console/bad_extension_page/manifest.json
(right):

https://codereview.chromium.org/133003003/diff/30002/chrome/test/data/extensi...
chrome/test/data/extensions/error_console/bad_extension_page/manifest.json:3:
"description": "An extension which breaks when visiting the new tab page",
On 2014/01/22 01:38:19, Yoyo Zhou wrote:
> Perhaps "throws an error" instead of "breaks"?

Done.

[commit-bot: I haz the power, 2014-01-22 02:01:25]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rdevlin.cronin@chromium.org/133003003/...

[commit-bot: I haz the power, 2014-01-22 02:59:36]

Retried try job too often on chromium_presubmit for step(s) presubmit
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_p...

[commit-bot: I haz the power, 2014-01-22 03:12:00]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rdevlin.cronin@chromium.org/133003003/...

[commit-bot: I haz the power, 2014-01-22 09:21:53]

Change committed as 246252