Make ErrorConsole catch errors from Extension WebContents Views

chrome/browser/extensions/error_console/error_console_browsertest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/error_console/error_console.h"
 
 #include "base/files/file_path.h"
 #include "base/prefs/pref_service.h"
 #include "base/strings/string16.h"
 #include "base/strings/stringprintf.h"
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/browser/extensions/extension_browsertest.h"
 #include "chrome/browser/extensions/extension_toolbar_model.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/common/pref_names.h"
+#include "chrome/common/url_constants.h"
 #include "chrome/test/base/ui_test_utils.h"
 #include "extensions/browser/extension_error.h"
 #include "extensions/common/constants.h"
 #include "extensions/common/error_utils.h"
 #include "extensions/common/extension.h"
 #include "extensions/common/extension_urls.h"
 #include "extensions/common/feature_switch.h"
 #include "extensions/common/manifest_constants.h"
 #include "net/test/embedded_test_server/embedded_test_server.h"
 #include "testing/gtest/include/gtest/gtest.h"
@@ skipping 154 matching lines @@
     bool waiting_;
 
     ErrorConsole* error_console_;
 
     DISALLOW_COPY_AND_ASSIGN(ErrorObserver);
   };
 
   // The type of action which we take after we load an extension in order to
   // cause any errors.
   enum Action {
-    ACTION_NAVIGATE,  // navigate to a page to allow a content script to run.
-    ACTION_BROWSER_ACTION,  // simulate a browser action click.
-    ACTION_NONE  // Do nothing (errors will be caused by a background script,
-                 // or by a manifest/loading warning).
+    // Navigate to a (non-chrome) page to allow a content script to run.
+    ACTION_NAVIGATE,
+    // Simulate a browser action click.
+    ACTION_BROWSER_ACTION,
+    // Navigate to the new tab page.
+    ACTION_NEW_TAB,
+    // Do nothing (errors will be caused by a background script,
+    // or by a manifest/loading warning).
+    ACTION_NONE
   };
 
   virtual void SetUpInProcessBrowserTestFixture() OVERRIDE {
     ExtensionBrowserTest::SetUpInProcessBrowserTestFixture();
 
     // We need to enable the ErrorConsole FeatureSwitch in order to collect
     // errors.
     FeatureSwitch::error_console()->SetOverrideValue(
         FeatureSwitch::OVERRIDE_ENABLED);
   }
@@ skipping 35 matching lines @@
     switch (action) {
       case ACTION_NAVIGATE: {
         ui_test_utils::NavigateToURL(browser(), GetTestURL());
         break;
       }
       case ACTION_BROWSER_ACTION: {
         ExtensionToolbarModel::Get(profile())->ExecuteBrowserAction(
             *extension, browser(), NULL, true);
         break;
       }
+      case ACTION_NEW_TAB: {
+        ui_test_utils::NavigateToURL(browser(),
+                                     GURL(chrome::kChromeUINewTabURL));
+        break;
+      }
       case ACTION_NONE:
         break;
       default:
         NOTREACHED();
     }
 
     observer.WaitForErrors();
 
     // We should only have errors for a single extension, or should have no
     // entries, if no errors were expected.
@@ skipping 254 matching lines @@
       1u);
 
   const StackTrace& stack_trace = GetStackTraceFromError(errors[0]);
   ASSERT_EQ(1u, stack_trace.size());
   CheckStackFrame(stack_trace[0],
                   script_url,
                   kAnonymousFunction,
                   5u, 1u);
 }
 
+IN_PROC_BROWSER_TEST_F(ErrorConsoleBrowserTest, BadExtensionPage) {
+  const Extension* extension = NULL;
+  LoadExtensionAndCheckErrors(
+      "bad_extension_page",
+      kNoFlags,
+      1,  // One error: the page will load JS which has a reference error.
+      ACTION_NEW_TAB,
+      &extension);
+}
+
 }  // namespace extensions