Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1125)

Unified Diff: pkg/compiler/lib/src/dart_backend/placeholder_collector.dart

Issue 1325843003: Add optional message to assert in Dart2js. (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Reintroduce assertHelper for asserts without messages. Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/dart_backend/placeholder_collector.dart
diff --git a/pkg/compiler/lib/src/dart_backend/placeholder_collector.dart b/pkg/compiler/lib/src/dart_backend/placeholder_collector.dart
index ed0c6bc9ee3ba4d8a396671d6987838b53536b0e..b15e76a81dc0480c331c846a0f8a35a9e395090c 100644
--- a/pkg/compiler/lib/src/dart_backend/placeholder_collector.dart
+++ b/pkg/compiler/lib/src/dart_backend/placeholder_collector.dart
@@ -45,9 +45,7 @@ class SendVisitor extends Visitor {
visitSend(Send node) {
Element element = elements[node];
- if (elements.isAssert(node)) {
- return;
- } else if (elements.isTypeLiteral(node)) {
+ if (elements.isTypeLiteral(node)) {
DartType type = elements.getTypeLiteralType(node);
if (!type.isDynamic) {
if (type is TypeVariableType) {
@@ -139,7 +137,6 @@ class SendVisitor extends Visitor {
collector.currentElement, element, node);
if (Elements.isUnresolved(element)
- || elements.isAssert(node)
|| element.isDeferredLoaderGetter) {
return;
}

Powered by Google App Engine
This is Rietveld 408576698