Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(872)

Unified Diff: pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart

Issue 1325843003: Add optional message to assert in Dart2js. (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Reintroduce assertHelper for asserts without messages. Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart
diff --git a/pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart b/pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart
index 8ad289f9d38028b1ea429755a024a6f78450792b..8896bf455feedf9c16b3384299983e9ca7b83d62 100644
--- a/pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart
+++ b/pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart
@@ -650,20 +650,6 @@ abstract class IrBuilderVisitor extends ast.Visitor<ir.Primitive>
// ## Sends ##
@override
- ir.Primitive visitAssert(ast.Send node, ast.Node condition, _) {
- assert(irBuilder.isOpen);
- if (compiler.enableUserAssertions) {
- return giveup(node, 'assert in checked mode not implemented');
- } else {
- // The call to assert and its argument expression must be ignored
- // in production mode.
- // Assertions can only occur in expression statements, so no value needs
- // to be returned.
- return null;
- }
- }
-
- @override
void previsitDeferredAccess(ast.Send node, PrefixElement prefix, _) {
giveup(node, 'deferred access is not implemented');
}

Powered by Google App Engine
This is Rietveld 408576698