Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(253)

Issue 13248004: Cleaning up apps codelab (Closed)

Created:
7 years, 9 months ago by mkearney1
Modified:
7 years, 8 months ago
CC:
chromium-reviews, Aaron Boodman, chromium-apps-reviews_chromium.org
Visibility:
Public.

Description

Cleaning up apps codelab Adding proper navigation, rewriting introductions to flow better, covering JavaScript and AngularJS samples, and including new tabs for code snippets. BUG=162992 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=194252

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Patch Set 7 : #

Patch Set 8 : #

Patch Set 9 : #

Patch Set 10 : #

Patch Set 11 : #

Patch Set 12 : #

Total comments: 56

Patch Set 13 : #

Patch Set 14 : #

Total comments: 6

Patch Set 15 : #

Patch Set 16 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1409 lines, -400 lines) Patch
M chrome/common/extensions/docs/templates/articles/app_codelab.html View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +57 lines, -38 lines 0 comments Download
M chrome/common/extensions/docs/templates/articles/app_codelab1_setup.html View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 2 chunks +5 lines, -7 lines 0 comments Download
M chrome/common/extensions/docs/templates/articles/app_codelab2_basic.html View 1 2 3 4 5 6 7 8 9 10 11 12 13 5 chunks +81 lines, -40 lines 0 comments Download
M chrome/common/extensions/docs/templates/articles/app_codelab3_mvc.html View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 4 chunks +310 lines, -48 lines 0 comments Download
D chrome/common/extensions/docs/templates/articles/app_codelab4_testing.html View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +0 lines, -8 lines 0 comments Download
M chrome/common/extensions/docs/templates/articles/app_codelab5_data.html View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 5 chunks +304 lines, -48 lines 0 comments Download
M chrome/common/extensions/docs/templates/articles/app_codelab6_lifecycle.html View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 4 chunks +120 lines, -33 lines 0 comments Download
M chrome/common/extensions/docs/templates/articles/app_codelab7_useridentification.html View 1 2 3 4 5 6 7 8 9 10 11 12 13 5 chunks +100 lines, -24 lines 0 comments Download
M chrome/common/extensions/docs/templates/articles/app_codelab8_webresources.html View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 5 chunks +348 lines, -64 lines 0 comments Download
M chrome/common/extensions/docs/templates/articles/app_codelab9_multipleviews.html View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +0 lines, -57 lines 0 comments Download
M chrome/common/extensions/docs/templates/articles/app_codelab_10_publishing.html View 1 2 3 4 5 6 7 8 9 10 11 12 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/common/extensions/docs/templates/articles/develop_apps.html View 1 2 3 4 3 chunks +34 lines, -23 lines 0 comments Download
M chrome/common/extensions/docs/templates/json/apps_sidenav.json View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 2 chunks +48 lines, -5 lines 0 comments Download
D chrome/common/extensions/docs/templates/public/apps/app_codelab4_testing.html View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +0 lines, -1 line 0 comments Download
D chrome/common/extensions/docs/templates/public/apps/app_codelab9_multipleviews.html View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
mkearney1
Hey, Renato Here's the codelab all cleaned up. I'll send a link to the staged ...
7 years, 8 months ago (2013-04-08 22:22:58 UTC) #1
Renato Mangini (chromium)
Great job, Meggin! Several comments along the content, but it is a solid change list. ...
7 years, 8 months ago (2013-04-09 17:32:32 UTC) #2
mkearney
Cool, thanks. I'm waiting for gclient sync-- first one since blink, and then I can ...
7 years, 8 months ago (2013-04-09 17:38:49 UTC) #3
mkearney1
Hopefully we are closer... https://codereview.chromium.org/13248004/diff/25001/chrome/common/extensions/docs/static/css/site.css File chrome/common/extensions/docs/static/css/site.css (right): https://codereview.chromium.org/13248004/diff/25001/chrome/common/extensions/docs/static/css/site.css#newcode596 chrome/common/extensions/docs/static/css/site.css:596: } On 2013/04/09 17:32:32, Renato ...
7 years, 8 months ago (2013-04-10 17:59:58 UTC) #4
Renato Mangini (chromium)
Aside from a few nits, lgtm https://codereview.chromium.org/13248004/diff/35003/chrome/common/extensions/docs/templates/articles/app_codelab1_setup.html File chrome/common/extensions/docs/templates/articles/app_codelab1_setup.html (right): https://codereview.chromium.org/13248004/diff/35003/chrome/common/extensions/docs/templates/articles/app_codelab1_setup.html#newcode7 chrome/common/extensions/docs/templates/articles/app_codelab1_setup.html:7: <li><p>Open your preferred ...
7 years, 8 months ago (2013-04-12 20:33:06 UTC) #5
mkearney1
Trying to commit now-- getting merge conflicts but hopefully will push past them soon. https://codereview.chromium.org/13248004/diff/35003/chrome/common/extensions/docs/templates/articles/app_codelab1_setup.html ...
7 years, 8 months ago (2013-04-15 20:48:12 UTC) #6
mkearney1
7 years, 8 months ago (2013-04-15 22:56:18 UTC) #7
Message was sent while issue was closed.
Committed patchset #16 manually as r194252 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698