Open-source histograms.xml, starting with Autofill histograms.

Open-source histograms.xml, starting with Autofill histograms.

The histograms.xml file contains human-readable descriptions for UMA histograms.
Moving these descriptions out into the Chromium repository simplifies live for
folks adding new histograms, as most will now only have to fiddle with
committing to a single repository.

BUG=223859
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=191540

[Ilya Sherman, 2013-03-29 01:37:52]

Marking this issue as private for now, just in case I've accidentally included
anything that shouldn't be open-sourced.  PTAL.

[mal, 2013-03-29 04:40:14]

No clue. I am not qualified to review this.

How much of the adds are just pulling .py files from chrome-internal to chrome?
Anything that's changed should get a review from a python hacker (there are
plenty on chrome-infrastructure-team). 

There are several <obsolete> blocks in histograms.xml... do we need to carry
those forward, or can we safely drop them at this point (the two I spotted were
both >9 months old).

[Ilya Sherman, 2013-03-29 08:22:53]

On 2013/03/29 04:40:14, mal wrote:
> No clue. I am not qualified to review this.

Alrighty.  I mostly added you to the reviewer list in case there is anything in
general that I should be doing when open-sourcing previously closed-source code.

> How much of the adds are just pulling .py files from chrome-internal to
chrome?
> Anything that's changed should get a review from a python hacker (there are
> plenty on chrome-infrastructure-team). 

Almost all of the changes are just file copies.  Aside from updating license
blocks and file paths, there are very few actual changes, which I've gone
through and highlighted via inline comments.

> There are several <obsolete> blocks in histograms.xml... do we need to carry
> those forward, or can we safely drop them at this point (the two I spotted
were
> both >9 months old).

I think the best practice we'd established for the internal repo was to keep
them as documentation.  This might be something to revisit in the future, but
I'd rather keep them for now, for the sake of minimal deviation from what's
checked in internally.

https://chromiumcodereview.appspot.com/13245008/diff/1/tools/metrics/histogra...
File tools/metrics/histograms/extract_histograms.py (right):

https://chromiumcodereview.appspot.com/13245008/diff/1/tools/metrics/histogra...
tools/metrics/histograms/extract_histograms.py:362: raise Error()
This was sys.exit(1) in the internal repo.

https://chromiumcodereview.appspot.com/13245008/diff/1/tools/metrics/histogra...
File tools/metrics/histograms/pretty_print.py (right):

https://chromiumcodereview.appspot.com/13245008/diff/1/tools/metrics/histogra...
tools/metrics/histograms/pretty_print.py:32: 'histogram': ['name', 'enum',
'units'],
Dropped "dummy" and TODO here.

https://chromiumcodereview.appspot.com/13245008/diff/1/tools/metrics/histogra...
tools/metrics/histograms/pretty_print.py:53: 'enums': (2, 1, 1),
Changed from (2, 2, 1) to (2, 1, 1)

[Ilya Sherman, 2013-03-29 08:24:15]

https://chromiumcodereview.appspot.com/13245008/diff/1/tools/metrics/histogra...
File tools/metrics/histograms/validate_format.py (right):

https://chromiumcodereview.appspot.com/13245008/diff/1/tools/metrics/histogra...
tools/metrics/histograms/validate_format.py:16: main()
And this file is new, because "import extract_histograms" didn't work directly
from the PRESUBMIT script

[jar (doing other things), 2013-03-29 22:20:44]

I didn't do a careful review of the python scripts, and I'm assuming they are
(other than your comments about minor changes) identical to previous Chrome
based incarnations.

LGTM

[commit-bot: I haz the power, 2013-03-29 22:21:57]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/isherman@chromium.org/13245008/1

[commit-bot: I haz the power, 2013-03-30 17:03:56]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/isherman@chromium.org/13245008/1

[commit-bot: I haz the power, 2013-03-30 19:08:46]

Change committed as 191540