Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(950)

Unified Diff: Source/core/html/HTMLIFrameElement.cpp

Issue 1319863006: (blink) Propagate scrolling/marginwidth/marginheight property values to child frame. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Update. Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/html/HTMLIFrameElement.cpp
diff --git a/Source/core/html/HTMLIFrameElement.cpp b/Source/core/html/HTMLIFrameElement.cpp
index ef5413c522711007db13895f5ceceafad5062fee..0e9c998a85561dad80e65109e7c7d778c39f1e65 100644
--- a/Source/core/html/HTMLIFrameElement.cpp
+++ b/Source/core/html/HTMLIFrameElement.cpp
@@ -120,6 +120,19 @@ void HTMLIFrameElement::parseAttribute(const QualifiedName& name, const AtomicSt
} else if (name == sandboxAttr) {
m_sandbox->setValue(value);
UseCounter::count(document(), UseCounter::SandboxViaIFrame);
+ } else if (name == marginwidthAttr) {
dcheng 2015/09/02 06:38:26 I believe these attributes are supported on <frame
lazyboy 2015/09/02 16:56:30 Right, I forgot to move these back to FrameElement
+ setMarginWidth(value.toInt());
+ // FIXME: If we are already attached, this has no effect.
+ } else if (name == marginheightAttr) {
+ setMarginHeight(value.toInt());
+ // FIXME: If we are already attached, this has no effect.
+ } else if (name == scrollingAttr) {
+ // Auto and yes both simply mean "allow scrolling." No means "don't allow scrolling."
+ if (equalIgnoringCase(value, "auto") || equalIgnoringCase(value, "yes"))
+ setScrollingMode(ScrollbarAuto);
+ else if (equalIgnoringCase(value, "no"))
+ setScrollingMode(ScrollbarAlwaysOff);
+ // FIXME: If we are already attached, this has no effect.
} else {
HTMLFrameElementBase::parseAttribute(name, value);
}

Powered by Google App Engine
This is Rietveld 408576698