(blink) Propagate scrolling/marginwidth/marginheight property values to child frame.

Source/core/html/HTMLIFrameElement.cpp

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  *           (C) 2000 Simon Hausmann (hausmann@kde.org)
  *           (C) 2001 Dirk Mueller (mueller@kde.org)
  * Copyright (C) 2004, 2006, 2008, 2009 Apple Inc. All rights reserved.
  * Copyright (C) 2009 Ericsson AB. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
@@ skipping 102 matching lines @@
     if (name == nameAttr) {
         if (inDocument() && document().isHTMLDocument() && !isInShadowTree()) {
             HTMLDocument& document = toHTMLDocument(this->document());
             document.removeExtraNamedItem(m_name);
             document.addExtraNamedItem(value);
         }
         m_name = value;
     } else if (name == sandboxAttr) {
         m_sandbox->setValue(value);
         UseCounter::count(document(), UseCounter::SandboxViaIFrame);
+    } else if (name == marginwidthAttr) {

[dcheng, 2015/09/02 06:38:26]

I believe these attributes are supported on <frame>, not just <iframe>.

[lazyboy, 2015/09/02 16:56:30]

Right, I forgot to move these back to FrameElementBase after experimenting.
Done.

+        setMarginWidth(value.toInt());
+        // FIXME: If we are already attached, this has no effect.
+    } else if (name == marginheightAttr) {
+        setMarginHeight(value.toInt());
+        // FIXME: If we are already attached, this has no effect.
+    } else if (name == scrollingAttr) {
+        // Auto and yes both simply mean "allow scrolling." No means "don't allow scrolling."
+        if (equalIgnoringCase(value, "auto") || equalIgnoringCase(value, "yes"))
+            setScrollingMode(ScrollbarAuto);
+        else if (equalIgnoringCase(value, "no"))
+            setScrollingMode(ScrollbarAlwaysOff);
+        // FIXME: If we are already attached, this has no effect.
     } else {
         HTMLFrameElementBase::parseAttribute(name, value);
     }
 }
 
 bool HTMLIFrameElement::layoutObjectIsNeeded(const ComputedStyle& style)
 {
     return isURLAllowed() && HTMLElement::layoutObjectIsNeeded(style);
 }
 
@@ skipping 34 matching lines @@
 void HTMLIFrameElement::valueChanged()
 {
     String invalidTokens;
     setSandboxFlags(m_sandbox->value().isNull() ? SandboxNone : parseSandboxPolicy(m_sandbox->tokens(), invalidTokens));
     if (!invalidTokens.isNull())
         document().addConsoleMessage(ConsoleMessage::create(OtherMessageSource, ErrorMessageLevel, "Error while parsing the 'sandbox' attribute: " + invalidTokens));
     setSynchronizedLazyAttribute(sandboxAttr, m_sandbox->value());
 }
 
 }