(blink) Propagate scrolling/marginwidth/marginheight property values to child frame.

Source/core/html/HTMLFrameOwnerElement.cpp

Index: Source/core/html/HTMLFrameOwnerElement.cpp
diff --git a/Source/core/html/HTMLFrameOwnerElement.cpp b/Source/core/html/HTMLFrameOwnerElement.cpp
index c5e86452bda6fdf90a35d11a7361475580564615..d11d2919576f5f9485ab0e92b8168dad0daf0d6d 100644
--- a/Source/core/html/HTMLFrameOwnerElement.cpp
+++ b/Source/core/html/HTMLFrameOwnerElement.cpp
@@ -109,6 +109,9 @@ HTMLFrameOwnerElement::HTMLFrameOwnerElement(const QualifiedName& tagName, Docum
     , m_contentFrame(nullptr)
     , m_widget(nullptr)
     , m_sandboxFlags(SandboxNone)
+    , m_scrollingMode(ScrollbarAuto)
+    , m_marginWidth(-1)
+    , m_marginHeight(-1)
 {
 }
 
@@ -191,6 +194,39 @@ void HTMLFrameOwnerElement::setSandboxFlags(SandboxFlags flags)
         document().frame()->loader().client()->didChangeSandboxFlags(contentFrame(), flags);
 }
 
+void HTMLFrameOwnerElement::setScrollingMode(ScrollbarMode scrollbarMode)
+{
+    m_scrollingMode = scrollbarMode;
+    if (isPluginElement())
+        return;
+    // Don't notify about updates if contentFrame() is null, for example when
+    // the subframe hasn't been created yet.
+    if (contentFrame())
+        document().frame()->loader().client()->didChangeScrollingMode(contentFrame(), scrollbarMode);

[alexmos, 2015/09/16 00:36:47]

You're using three separate IPCs to propagate these updates to the browser
process, but then they get squished into the same
FrameMsg_SetFrameOwnerProperties on the way back to the renderer.  Should we be
consistent and either use one IPC here for all three things, or use different
IPCs on browser->renderer path too?

[lazyboy, 2015/09/17 20:48:39]

I've made renderer->browser one IPC too, with the cost of saving the
current frame owner properties state in RenderFrameImpl.

[alexmos, 2015/09/21 16:58:07]

Is there a way to avoid storing them on RenderFrameImpl?  I'm worried about
whether they'd be initialized/reset there at proper times.  What about passing
them all through WebFrameClient any time one of them changes?

[lazyboy, 2015/09/21 18:04:51]

changed all functions to one: didChangeFrameOwnerProperties() and calling that
whenever one of the properties change.

+}
+
+void HTMLFrameOwnerElement::setMarginWidth(int marginWidth)
+{
+    m_marginWidth = marginWidth;
+    if (isPluginElement())
+        return;
+    // Don't notify about updates if contentFrame() is null, for example when
+    // the subframe hasn't been created yet.
+    if (contentFrame())
+        document().frame()->loader().client()->didChangeMarginWidth(contentFrame(), m_marginWidth);
+}
+
+void HTMLFrameOwnerElement::setMarginHeight(int marginHeight)
+{
+    m_marginHeight = marginHeight;
+    if (isPluginElement())
+        return;
+    // Don't notify about updates if contentFrame() is null, for example when
+    // the subframe hasn't been created yet.
+    if (contentFrame())
+        document().frame()->loader().client()->didChangeMarginHeight(contentFrame(), m_marginHeight);
+}
+
 bool HTMLFrameOwnerElement::isKeyboardFocusable() const
 {
     return m_contentFrame && HTMLElement::isKeyboardFocusable();