(blink) Propagate scrolling/marginwidth/marginheight property values to child frame.

Source/core/html/HTMLFrameOwnerElement.cpp

 /*
  * Copyright (C) 2006, 2007, 2009 Apple Inc. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
  *
  * This library is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 91 matching lines @@
         return;
     }
     widgetNewParentMap().set(child, parent);
 }
 
 HTMLFrameOwnerElement::HTMLFrameOwnerElement(const QualifiedName& tagName, Document& document)
     : HTMLElement(tagName, document)
     , m_contentFrame(nullptr)
     , m_widget(nullptr)
     , m_sandboxFlags(SandboxNone)
+    , m_scrollingMode(ScrollbarAuto)
+    , m_marginWidth(-1)
+    , m_marginHeight(-1)
 {
 }
 
 LayoutPart* HTMLFrameOwnerElement::layoutPart() const
 {
     // HTMLObjectElement and HTMLEmbedElement may return arbitrary layoutObjects
     // when using fallback content.
     if (!layoutObject() || !layoutObject()->isLayoutPart())
         return nullptr;
     return toLayoutPart(layoutObject());
@@ skipping 62 matching lines @@
 
 void HTMLFrameOwnerElement::setSandboxFlags(SandboxFlags flags)
 {
     m_sandboxFlags = flags;
     // Don't notify about updates if contentFrame() is null, for example when
     // the subframe hasn't been created yet.
     if (contentFrame())
         document().frame()->loader().client()->didChangeSandboxFlags(contentFrame(), flags);
 }
 
+void HTMLFrameOwnerElement::setScrollingMode(ScrollbarMode scrollbarMode)
+{
+    m_scrollingMode = scrollbarMode;
+    if (isPluginElement())
+        return;
+    // Don't notify about updates if contentFrame() is null, for example when
+    // the subframe hasn't been created yet.
+    if (contentFrame())
+        document().frame()->loader().client()->didChangeScrollingMode(contentFrame(), scrollbarMode);

[alexmos, 2015/09/16 00:36:47]

You're using three separate IPCs to propagate these updates to the browser
process, but then they get squished into the same
FrameMsg_SetFrameOwnerProperties on the way back to the renderer.  Should we be
consistent and either use one IPC here for all three things, or use different
IPCs on browser->renderer path too?

[lazyboy, 2015/09/17 20:48:39]

I've made renderer->browser one IPC too, with the cost of saving the
current frame owner properties state in RenderFrameImpl.

[alexmos, 2015/09/21 16:58:07]

Is there a way to avoid storing them on RenderFrameImpl?  I'm worried about
whether they'd be initialized/reset there at proper times.  What about passing
them all through WebFrameClient any time one of them changes?

[lazyboy, 2015/09/21 18:04:51]

changed all functions to one: didChangeFrameOwnerProperties() and calling that
whenever one of the properties change.

+}
+
+void HTMLFrameOwnerElement::setMarginWidth(int marginWidth)
+{
+    m_marginWidth = marginWidth;
+    if (isPluginElement())
+        return;
+    // Don't notify about updates if contentFrame() is null, for example when
+    // the subframe hasn't been created yet.
+    if (contentFrame())
+        document().frame()->loader().client()->didChangeMarginWidth(contentFrame(), m_marginWidth);
+}
+
+void HTMLFrameOwnerElement::setMarginHeight(int marginHeight)
+{
+    m_marginHeight = marginHeight;
+    if (isPluginElement())
+        return;
+    // Don't notify about updates if contentFrame() is null, for example when
+    // the subframe hasn't been created yet.
+    if (contentFrame())
+        document().frame()->loader().client()->didChangeMarginHeight(contentFrame(), m_marginHeight);
+}
+
 bool HTMLFrameOwnerElement::isKeyboardFocusable() const
 {
     return m_contentFrame && HTMLElement::isKeyboardFocusable();
 }
 
 void HTMLFrameOwnerElement::dispatchLoad()
 {
     dispatchEvent(Event::create(EventTypeNames::load));
 }
 
@@ skipping 72 matching lines @@
 DEFINE_TRACE(HTMLFrameOwnerElement)
 {
     visitor->trace(m_contentFrame);
     visitor->trace(m_widget);
     HTMLElement::trace(visitor);
     FrameOwner::trace(visitor);
 }
 
 
 } // namespace blink