Pass app_locale directly to AutofillTable

Pass app_locale directly to AutofillTable

(instead of sending it on a tour of *all* the WebData classes).

TBR=rrobertshield@chromium.org
(chrome-frame test fix)
BUG=181277
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=191759

[Cait (Slow), 2013-03-28 17:30:58]

Hi David,

This is a second pass at the app_locale clean-up. I was about to add the test
you suggested, but then realized that rather than passing the app_locale through
all the WebDB layers, we can actually access it in the ctor of the AutofillTable
directly (as the table is now getting created in WebDataServiceFactory, on the
UI thread, but not initialized until the DB is, on the DB thread).

The current impl assumes that the AutofillTable will be created on the UI
thread. If this seems risky, we could pass the app_locale in as a param instead
(since we know WebDBFactory runs on the UI thread).

wdyt?

[dhollowa, 2013-03-28 18:01:05]

On 2013/03/28 17:30:58, caitkp wrote:
> Hi David,
> 
> This is a second pass at the app_locale clean-up. I was about to add the test
> you suggested, but then realized that rather than passing the app_locale
through
> all the WebDB layers, we can actually access it in the ctor of the
AutofillTable
> directly (as the table is now getting created in WebDataServiceFactory, on the
> UI thread, but not initialized until the DB is, on the DB thread).
> 
> The current impl assumes that the AutofillTable will be created on the UI
> thread. If this seems risky, we could pass the app_locale in as a param
instead
> (since we know WebDBFactory runs on the UI thread).
> 
> wdyt?

I like it.  LGTM.  But please wait for comment from isherman@ as he did this
original work.

[dhollowa, 2013-03-28 18:01:30]

+isherman

[Ilya Sherman, 2013-03-28 21:31:44]

passwords/ LGTM

[Cait (Slow), 2013-03-28 22:11:53]

On 2013/03/28 21:31:44, Ilya Sherman wrote:
> passwords/ LGTM

Ilya -- would you mind taking a quick look at the changes to AutofillTable too?
This change touches the migration code there, and I want to make sure there
aren't any subtleties I'm missing.

Thanks.

[Ilya Sherman, 2013-03-28 22:21:21]

AutofillTable changes LGTM as well.

[commit-bot: I haz the power, 2013-04-01 16:18:09]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/caitkp@chromium.org/13191007/16002

[commit-bot: I haz the power, 2013-04-01 17:30:20]

Sorry for I got bad news for ya.
Compile failed with a clobber build on win.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win&number...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2013-04-01 17:44:45]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/caitkp@chromium.org/13191007/12005

[commit-bot: I haz the power, 2013-04-02 01:33:10]

Retried try job too often on win_rel for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2013-04-02 02:12:51]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/caitkp@chromium.org/13191007/12005

[commit-bot: I haz the power, 2013-04-02 03:40:13]

Change committed as 191759