Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Side by Side Diff: chrome/browser/webdata/web_database_table.h

Issue 13191007: Pass app_locale directly to AutofillTable (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Chrome frame tests fix Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_WEBDATA_WEB_DATABASE_TABLE_H_ 5 #ifndef CHROME_BROWSER_WEBDATA_WEB_DATABASE_TABLE_H_
6 #define CHROME_BROWSER_WEBDATA_WEB_DATABASE_TABLE_H_ 6 #define CHROME_BROWSER_WEBDATA_WEB_DATABASE_TABLE_H_
7 7
8 #include "base/logging.h" 8 #include "base/logging.h"
9 9
10 namespace sql { 10 namespace sql {
(...skipping 26 matching lines...) Expand all
37 // In order to encourage developers to think about sync when adding or 37 // In order to encourage developers to think about sync when adding or
38 // or altering new tables, this method must be implemented. Please get in 38 // or altering new tables, this method must be implemented. Please get in
39 // contact with the sync team if you believe you're making a change that they 39 // contact with the sync team if you believe you're making a change that they
40 // should be aware of (or if you could break something). 40 // should be aware of (or if you could break something).
41 // TODO(andybons): Implement something more robust. 41 // TODO(andybons): Implement something more robust.
42 virtual bool IsSyncable() = 0; 42 virtual bool IsSyncable() = 0;
43 43
44 // Migrates this table to |version|. Returns false if there was 44 // Migrates this table to |version|. Returns false if there was
45 // migration work to do and it failed, true otherwise. 45 // migration work to do and it failed, true otherwise.
46 // 46 //
47 // |app_locale| is the locale of the app. Passed as a parameter as
48 // |it can only be safely queried on the UI thread.
49 //
50 // Implementations may set |*update_compatible_version| to true if 47 // Implementations may set |*update_compatible_version| to true if
51 // the compatible version should be changed to |version|. 48 // the compatible version should be changed to |version|.
52 // Implementations should otherwise not modify this parameter. 49 // Implementations should otherwise not modify this parameter.
53 virtual bool MigrateToVersion(int version, 50 virtual bool MigrateToVersion(int version,
54 const std::string& app_locale,
55 bool* update_compatible_version) = 0; 51 bool* update_compatible_version) = 0;
56 52
57 protected: 53 protected:
58 // Non-owning. These are owned by WebDatabase, valid as long as that 54 // Non-owning. These are owned by WebDatabase, valid as long as that
59 // class exists. Since lifetime of WebDatabaseTable objects slightly 55 // class exists. Since lifetime of WebDatabaseTable objects slightly
60 // exceeds that of WebDatabase, they should not be used in 56 // exceeds that of WebDatabase, they should not be used in
61 // ~WebDatabaseTable. 57 // ~WebDatabaseTable.
62 sql::Connection* db_; 58 sql::Connection* db_;
63 sql::MetaTable* meta_table_; 59 sql::MetaTable* meta_table_;
64 60
65 private: 61 private:
66 DISALLOW_COPY_AND_ASSIGN(WebDatabaseTable); 62 DISALLOW_COPY_AND_ASSIGN(WebDatabaseTable);
67 }; 63 };
68 64
69 #endif // CHROME_BROWSER_WEBDATA_WEB_DATABASE_TABLE_H_ 65 #endif // CHROME_BROWSER_WEBDATA_WEB_DATABASE_TABLE_H_
OLDNEW
« no previous file with comments | « chrome/browser/webdata/web_database_service.cc ('k') | chrome/browser/webdata/web_intents_table.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698