Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 1317253004: MIPS32: Simplify set of condition codes.

Created:
5 years, 3 months ago by paul.l...
Modified:
5 years, 3 months ago
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS32: Simplify set of condition codes. Cut down the condition codes to a more manageable list. This is WIP, need to still factor out many badly named cc aliases that are still in use. BUG=

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -56 lines) Patch
M src/mips/constants-mips.h View 2 chunks +74 lines, -56 lines 2 comments Download

Messages

Total messages: 3 (1 generated)
paul.l...
PTAL, early WIP CL to make our set of condition codes less confusing. https://codereview.chromium.org/1317253004/diff/1/src/mips/constants-mips.h File ...
5 years, 3 months ago (2015-09-04 03:45:25 UTC) #2
balazs.kilvady
5 years, 3 months ago (2015-09-04 09:27:45 UTC) #3
I like these changes and vote for factoring out the aliases mentioned in comment
at line 656.

https://codereview.chromium.org/1317253004/diff/1/src/mips/constants-mips.h
File src/mips/constants-mips.h (right):

https://codereview.chromium.org/1317253004/diff/1/src/mips/constants-mips.h#n...
src/mips/constants-mips.h:682: 
On 2015/09/04 03:45:24, paul.l... wrote:
> This function is no longer needed. I had thought this would be useful in a TF
> function, but I was wrong.
> 
> That also means that the re-numbering above is not important, nor is this
> comment:
> // CC values for any comparison involving equality has LS bit set.
> 
> though it does not hurt anything, as long as we also comply with this comment:
> // Opposite conditions must be paired as odd/even numbers
> 
> This is not urgent now, but think this (when finished and bogus aliases are
> removed from rest of mips port) would be a nice cimplication and consistency
> cleanup. What do you guys think?

I think the unsused function should be removed but we can keep the odd/even
number pairs for conditions codes as it does not hurt now and might be useful
later.

Powered by Google App Engine
This is Rietveld 408576698