Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1315693002: SoM: upgrade Polymer from 0.5 to 1.0

Created:
5 years, 4 months ago by seanmccullough
Modified:
5 years ago
Reviewers:
CC:
chromium-reviews, infra-reviews+infra_chromium.org
Base URL:
https://chromium.googlesource.com/infra/infra.git@master
Target Ref:
refs/heads/master
Project:
infra
Visibility:
Public.

Description

SoM: attempt to upgrade Polymer from 0.5 to 1.0 This CL doesn't work in its current state, it just demonstrates a lower bound on the amount of work necessary to upgrade the existing codebase to Polymer 1.0 (a task that may ultimately be determined to be unnecessary, admittedly) Most of these changes were generated by running polyup (<https://github.com/PolymerLabs/polyup>) on .html files in SoM. polyup choked on a few of the files, so they had to be hand-edited: ui/ct-failure-stream.html ui/ct-sheriff-o-matic.html ui/ct-user-prefs-editor.html model/ct-failure-group.html Some of the changes made by polyup don't make a lot of sense at first glance (e.g. always adding <html><head> to the start of every html file). BUG=

Patch Set 1 #

Patch Set 2 : get bower_components from polymer_1.0.4 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1493 lines, -1047 lines) Patch
M appengine/sheriff_o_matic/bower_components View 1 1 chunk +1 line, -1 line 0 comments Download
M appengine/sheriff_o_matic/model/ct-failures.html View 1 chunk +1 line, -3 lines 0 comments Download
M appengine/sheriff_o_matic/model/ct-repository.html View 1 chunk +2 lines, -3 lines 0 comments Download
M appengine/sheriff_o_matic/model/ct-rotations.html View 1 chunk +1 line, -3 lines 0 comments Download
M appengine/sheriff_o_matic/model/tree-status.html View 1 chunk +1 line, -3 lines 0 comments Download
M appengine/sheriff_o_matic/ui/ct-alert-card.html View 2 chunks +59 lines, -24 lines 0 comments Download
M appengine/sheriff_o_matic/ui/ct-alert-card-buttons.html View 2 chunks +21 lines, -10 lines 0 comments Download
M appengine/sheriff_o_matic/ui/ct-alert-extension.html View 1 chunk +14 lines, -6 lines 0 comments Download
M appengine/sheriff_o_matic/ui/ct-alerts.html View 1 chunk +19 lines, -9 lines 0 comments Download
M appengine/sheriff_o_matic/ui/ct-banner.html View 2 chunks +16 lines, -16 lines 0 comments Download
M appengine/sheriff_o_matic/ui/ct-build-failure-ext.html View 3 chunks +44 lines, -25 lines 0 comments Download
M appengine/sheriff_o_matic/ui/ct-builder.html View 1 chunk +19 lines, -13 lines 0 comments Download
M appengine/sheriff_o_matic/ui/ct-builder-failure-card.html View 2 chunks +17 lines, -10 lines 0 comments Download
M appengine/sheriff_o_matic/ui/ct-builder-grid.html View 1 chunk +10 lines, -6 lines 0 comments Download
M appengine/sheriff_o_matic/ui/ct-builder-status.html View 3 chunks +22 lines, -21 lines 0 comments Download
M appengine/sheriff_o_matic/ui/ct-button.html View 2 chunks +15 lines, -8 lines 0 comments Download
M appengine/sheriff_o_matic/ui/ct-chart.html View 1 chunk +20 lines, -13 lines 0 comments Download
M appengine/sheriff_o_matic/ui/ct-commit.html View 2 chunks +18 lines, -11 lines 0 comments Download
M appengine/sheriff_o_matic/ui/ct-commit-list.html View 3 chunks +142 lines, -113 lines 0 comments Download
M appengine/sheriff_o_matic/ui/ct-detailed-commit.html View 3 chunks +19 lines, -12 lines 0 comments Download
M appengine/sheriff_o_matic/ui/ct-embedded-flakiness-dashboard.html View 2 chunks +18 lines, -16 lines 0 comments Download
M appengine/sheriff_o_matic/ui/ct-failure-card-buttons.html View 2 chunks +36 lines, -34 lines 0 comments Download
M appengine/sheriff_o_matic/ui/ct-health.html View 1 chunk +32 lines, -10 lines 0 comments Download
M appengine/sheriff_o_matic/ui/ct-last-updated.html View 2 chunks +38 lines, -35 lines 0 comments Download
M appengine/sheriff_o_matic/ui/ct-master-failure-card.html View 2 chunks +41 lines, -32 lines 0 comments Download
M appengine/sheriff_o_matic/ui/ct-party-time.html View 2 chunks +9 lines, -10 lines 0 comments Download
M appengine/sheriff_o_matic/ui/ct-popout-iframe.html View 2 chunks +11 lines, -7 lines 0 comments Download
M appengine/sheriff_o_matic/ui/ct-popup-menu.html View 2 chunks +35 lines, -33 lines 0 comments Download
M appengine/sheriff_o_matic/ui/ct-results-by-builder.html View 2 chunks +48 lines, -14 lines 0 comments Download
M appengine/sheriff_o_matic/ui/ct-results-comparison.html View 2 chunks +40 lines, -33 lines 0 comments Download
M appengine/sheriff_o_matic/ui/ct-results-comparison-zoomer.html View 3 chunks +67 lines, -54 lines 0 comments Download
M appengine/sheriff_o_matic/ui/ct-results-detail.html View 2 chunks +85 lines, -61 lines 0 comments Download
M appengine/sheriff_o_matic/ui/ct-results-panel.html View 2 chunks +77 lines, -27 lines 0 comments Download
M appengine/sheriff_o_matic/ui/ct-step-failure-card.html View 2 chunks +22 lines, -19 lines 0 comments Download
M appengine/sheriff_o_matic/ui/ct-test-list.html View 4 chunks +60 lines, -39 lines 0 comments Download
M appengine/sheriff_o_matic/ui/ct-test-output.html View 2 chunks +71 lines, -28 lines 0 comments Download
M appengine/sheriff_o_matic/ui/ct-time-series.html View 2 chunks +83 lines, -74 lines 0 comments Download
M appengine/sheriff_o_matic/ui/ct-time-series-failure-card-buttons.html View 2 chunks +33 lines, -36 lines 0 comments Download
M appengine/sheriff_o_matic/ui/ct-tree-select.html View 1 chunk +31 lines, -34 lines 0 comments Download
M appengine/sheriff_o_matic/ui/ct-tree-status.html View 2 chunks +14 lines, -10 lines 0 comments Download
M appengine/sheriff_o_matic/ui/ct-trooper-card.html View 4 chunks +63 lines, -33 lines 0 comments Download
M appengine/sheriff_o_matic/ui/ct-unexpected-failures.html View 3 chunks +68 lines, -45 lines 0 comments Download
M appengine/sheriff_o_matic/ui/ct-user-prefs.html View 1 chunk +50 lines, -53 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
michaelpg
Wow, I'm kind of shocked at how well polyup apparently works. Did you try hand-editing ...
5 years ago (2015-12-05 00:43:54 UTC) #1
seanmccullough1
5 years ago (2015-12-05 01:41:27 UTC) #2 
On 2015/12/05 at 00:43:54, michaelpg wrote:
> Wow, I'm kind of shocked at how well polyup apparently works.
> 
> Did you try hand-editing the remaining files? Did anything in particular jump
out as broken, or are there just an arbitrary number of arbitrary bugs from an
imperfect conversion?

I did try hand-editing the remaining files, but there's a lot more to the
upgrade than string substitution. Some of the polymer elements used here (e.g.
scaffolding) don't exist any more in 1.0, and we'll have to replace them with
the 1.0 equivalents (which aren't drop-in replacements AFAICT).

It would be good to be able to rely on the unit tests (not in this CL, notably)
to verify that the logic is all intact after the upgrade but I think we'll have
to update a lot of the test code too.

Powered by Google App Engine
This is Rietveld 408576698