Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 1311613006: Update getColor calls that were deprecated in M. (Closed)

Created:
5 years, 3 months ago by aurimas (slooooooooow)
Modified:
5 years, 3 months ago
Reviewers:
newt (away)
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update getColor calls that were deprecated in M. BUG=503148 Committed: https://crrev.com/5ce763e1b18641c275ce5e1a021a495ffb9d0094 Cr-Commit-Position: refs/heads/master@{#347328}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -53 lines) Patch
M chrome/android/javatests/src/org/chromium/chrome/browser/omnibox/OmniboxUrlEmphasizerTest.java View 10 chunks +53 lines, -51 lines 1 comment Download
M chrome/android/javatests/src/org/chromium/chrome/browser/toolbar/BrandColorTest.java View 3 chunks +5 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
aurimas (slooooooooow)
PTAL
5 years, 3 months ago (2015-09-04 00:43:18 UTC) #2
newt (away)
lgtm https://chromiumcodereview.appspot.com/1311613006/diff/1/chrome/android/javatests/src/org/chromium/chrome/browser/omnibox/OmniboxUrlEmphasizerTest.java File chrome/android/javatests/src/org/chromium/chrome/browser/omnibox/OmniboxUrlEmphasizerTest.java (right): https://chromiumcodereview.appspot.com/1311613006/diff/1/chrome/android/javatests/src/org/chromium/chrome/browser/omnibox/OmniboxUrlEmphasizerTest.java#newcode132 chrome/android/javatests/src/org/chromium/chrome/browser/omnibox/OmniboxUrlEmphasizerTest.java:132: spans[0].assertIsColoredSpan("https", 0, ApiCompatibilityUtils.getColor(mResources, Did we ever consider naming ...
5 years, 3 months ago (2015-09-04 02:08:21 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1311613006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1311613006/1
5 years, 3 months ago (2015-09-04 02:08:48 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-04 03:06:55 UTC) #6
commit-bot: I haz the power
5 years, 3 months ago (2015-09-04 03:07:44 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5ce763e1b18641c275ce5e1a021a495ffb9d0094
Cr-Commit-Position: refs/heads/master@{#347328}

Powered by Google App Engine
This is Rietveld 408576698