Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Issue 1310353003: Material PDF: Variety of minor UI bugfixes (Closed)

Created:
5 years, 3 months ago by tsergeant
Modified:
5 years, 3 months ago
Reviewers:
raymes
CC:
arv+watch_chromium.org, chrome-apps-syd-reviews_chromium.org, chromium-reviews, dcheng
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Material PDF: Variety of minor UI bugfixes * Fix regression where dropdowns would not be sized correctly on first open. * Make page selector only accept numerical inputs * Position top toolbar z-level above zoom toolbar * Ellipsize long bookmark names BUG=527776, 527798, 526981 Committed: https://crrev.com/2667644160e695c5170d64ec0ee9759112e9b386 Cr-Commit-Position: refs/heads/master@{#347597}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix tests #

Messages

Total messages: 14 (5 generated)
tsergeant
~~~PTAL~~~
5 years, 3 months ago (2015-09-04 03:53:12 UTC) #2
raymes
nit in description: * Position top toolbar z-level about zoom toolbar about->above Looks good, just ...
5 years, 3 months ago (2015-09-05 01:41:33 UTC) #3
tsergeant
https://codereview.chromium.org/1310353003/diff/1/chrome/browser/resources/pdf/elements/viewer-page-selector/viewer-page-selector.css File chrome/browser/resources/pdf/elements/viewer-page-selector/viewer-page-selector.css (right): https://codereview.chromium.org/1310353003/diff/1/chrome/browser/resources/pdf/elements/viewer-page-selector/viewer-page-selector.css#newcode39 chrome/browser/resources/pdf/elements/viewer-page-selector/viewer-page-selector.css:39: margin: 0; On 2015/09/05 at 01:41:33, raymes wrote: > ...
5 years, 3 months ago (2015-09-07 00:05:11 UTC) #4
raymes
lgtm
5 years, 3 months ago (2015-09-07 00:06:48 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1310353003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1310353003/1
5 years, 3 months ago (2015-09-07 00:12:29 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/109623)
5 years, 3 months ago (2015-09-07 00:49:39 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1310353003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1310353003/20001
5 years, 3 months ago (2015-09-07 01:00:03 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 3 months ago (2015-09-07 02:21:14 UTC) #13
commit-bot: I haz the power
5 years, 3 months ago (2015-09-07 02:21:54 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2667644160e695c5170d64ec0ee9759112e9b386
Cr-Commit-Position: refs/heads/master@{#347597}

Powered by Google App Engine
This is Rietveld 408576698