chrome/browser/android/banners/app_banner_data_fetcher_android.h - Issue 1308533006: webapps: allow callers of icon downloader/selector to specify a minimum size

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/banners/app_banner_data_fetcher_android.h

Issue 1308533006: webapps: allow callers of icon downloader/selector to specify a minimum size (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@webapps-splashscreen-icon

Patch Set: Address review comments Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/src/org/chromium/chrome/browser/webapps/AddToHomescreenDialogHelper.java ('K') | « chrome/android/java/src/org/chromium/chrome/browser/webapps/AddToHomescreenDialogHelper.java ('k') | chrome/browser/android/banners/app_banner_data_fetcher_android.cc » ('j') | chrome/browser/android/banners/app_banner_manager_android.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/android/banners/app_banner_data_fetcher_android.h

diff --git a/chrome/browser/android/banners/app_banner_data_fetcher_android.h b/chrome/browser/android/banners/app_banner_data_fetcher_android.h

index 0f3a1274972ec173bc1e9708c4dc885b531b052c..4911f6e7638f58e8c95a76dc3898b9203aba767d 100644

--- a/chrome/browser/android/banners/app_banner_data_fetcher_android.h

+++ b/chrome/browser/android/banners/app_banner_data_fetcher_android.h

@@ -17,8 +17,10 @@ class AppBannerDataFetcherAndroid : public AppBannerDataFetcher {

AppBannerDataFetcherAndroid(

content::WebContents* web_contents,

base::WeakPtr<Delegate> weak_delegate,

+ int ideal_icon_size_in_dp,

+ int minimum_icon_size_in_dp,

int ideal_splash_image_size_in_dp,

- int ideal_icon_size_in_dp);

+ int minimum_splash_image_size_in_dp);

// Saves information about the Android app being promoted by the current page,

// then continues the creation pipeline.

@@ -45,6 +47,7 @@ class AppBannerDataFetcherAndroid : public AppBannerDataFetcher {

std::string native_app_package_;

int ideal_splash_image_size_in_dp_;

+ int minimum_splash_image_size_in_dp_;

DISALLOW_COPY_AND_ASSIGN(AppBannerDataFetcherAndroid);

};