Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2014)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/webapps/AddToHomescreenDialogHelper.java

Issue 1308533006: webapps: allow callers of icon downloader/selector to specify a minimum size (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@webapps-splashscreen-icon
Patch Set: Address review comments Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/webapps/AddToHomescreenDialogHelper.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/webapps/AddToHomescreenDialogHelper.java b/chrome/android/java/src/org/chromium/chrome/browser/webapps/AddToHomescreenDialogHelper.java
index 5b0309a9981f0f85f633617a5c59c7516f5d9557..abeb06204847407a07f6c7f51bd8cab5f43b9f7a 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/webapps/AddToHomescreenDialogHelper.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/webapps/AddToHomescreenDialogHelper.java
@@ -47,9 +47,7 @@ public class AddToHomescreenDialogHelper {
public void initialize(Observer observer) {
mObserver = observer;
mNativeAddToHomescreenDialogHelper = nativeInitialize(
- mTab.getWebContents(),
- ShortcutHelper.getIdealSplashImageSizeInDp(mAppContext.getResources()),
- ShortcutHelper.getIdealIconSizeInDp(mAppContext.getResources()));
+ mTab.getWebContents());
gone 2015/09/15 18:46:07 does this not fit on one line anymore? seemed fin
Lalit Maganti 2015/09/15 18:48:33 Done.
}
/**
@@ -100,8 +98,7 @@ public class AddToHomescreenDialogHelper {
ApplicationStatus.getApplicationContext(), icon, url, red, green, blue);
}
- private native long nativeInitialize(WebContents webContents,
- int idealSplashImageSizeInDp, int idealIconSizeInDp);
+ private native long nativeInitialize(WebContents webContents);
private native void nativeAddShortcut(long nativeAddToHomescreenDialogHelper,
String userRequestedTitle);
private native void nativeDestroy(long nativeAddToHomescreenDialogHelper);

Powered by Google App Engine
This is Rietveld 408576698