chrome/browser/banners/app_banner_data_fetcher.h - Issue 1308533006: webapps: allow callers of icon downloader/selector to specify a minimum size

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/banners/app_banner_data_fetcher.h

Issue 1308533006: webapps: allow callers of icon downloader/selector to specify a minimum size (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@webapps-splashscreen-icon

Patch Set: Address review comments Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/android/shortcut_helper.cc ('K') | « chrome/browser/android/webapps/add_to_homescreen_dialog_helper.cc ('k') | chrome/browser/banners/app_banner_data_fetcher.cc » ('j') | chrome/browser/manifest/manifest_icon_selector.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/banners/app_banner_data_fetcher.h

diff --git a/chrome/browser/banners/app_banner_data_fetcher.h b/chrome/browser/banners/app_banner_data_fetcher.h

index 6d06e56bfe0af61b9b4b6c632645c8f509c39a84..0fa8d53ccf6ede58dbfd079d5bd150622a93a712 100644

--- a/chrome/browser/banners/app_banner_data_fetcher.h

+++ b/chrome/browser/banners/app_banner_data_fetcher.h

@@ -57,7 +57,8 @@ class AppBannerDataFetcher

AppBannerDataFetcher(content::WebContents* web_contents,

base::WeakPtr<Delegate> weak_delegate,

- int ideal_icon_size_in_dp);

+ int ideal_icon_size_in_dp,

+ int minimum_icon_size_in_dp);

// Begins creating a banner for the URL being displayed by the Delegate's

// WebContents.

@@ -169,8 +170,9 @@ class AppBannerDataFetcher

static bool IsManifestValidForWebApp(const content::Manifest& manifest,

content::WebContents* web_contents);

- const int ideal_icon_size_in_dp_;

const base::WeakPtr<Delegate> weak_delegate_;

+ const int ideal_icon_size_in_dp_;

+ const int minimum_icon_size_in_dp_;

base::ObserverList<Observer> observer_list_;

bool is_active_;

bool was_canceled_by_page_;