Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(698)

Unified Diff: chrome/browser/android/webapps/add_to_homescreen_dialog_helper.cc

Issue 1308533006: webapps: allow callers of icon downloader/selector to specify a minimum size (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@webapps-splashscreen-icon
Patch Set: Address review comments Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/webapps/add_to_homescreen_dialog_helper.cc
diff --git a/chrome/browser/android/webapps/add_to_homescreen_dialog_helper.cc b/chrome/browser/android/webapps/add_to_homescreen_dialog_helper.cc
index a206314e8c9cbd353a61f8dec6534d98bd551d6c..affdd4173de966b719c8e6e741c43318c9144038 100644
--- a/chrome/browser/android/webapps/add_to_homescreen_dialog_helper.cc
+++ b/chrome/browser/android/webapps/add_to_homescreen_dialog_helper.cc
@@ -27,27 +27,24 @@ using content::Manifest;
jlong Initialize(JNIEnv* env,
const JavaParamRef<jobject>& obj,
- const JavaParamRef<jobject>& java_web_contents,
- jint ideal_splash_image_size_in_dp,
- jint ideal_icon_size_in_dp) {
+ const JavaParamRef<jobject>& java_web_contents) {
content::WebContents* web_contents =
content::WebContents::FromJavaWebContents(java_web_contents);
AddToHomescreenDialogHelper* add_to_homescreen_helper =
- new AddToHomescreenDialogHelper(env, obj, web_contents,
- ideal_splash_image_size_in_dp, ideal_icon_size_in_dp);
+ new AddToHomescreenDialogHelper(env, obj, web_contents);
return reinterpret_cast<intptr_t>(add_to_homescreen_helper);
}
AddToHomescreenDialogHelper::AddToHomescreenDialogHelper(
JNIEnv* env,
jobject obj,
- content::WebContents* web_contents,
- int ideal_splash_image_size_in_dp,
- int ideal_icon_size_in_dp)
+ content::WebContents* web_contents)
: add_shortcut_pending_(false),
data_fetcher_(new AddToHomescreenDataFetcher(web_contents,
- ideal_splash_image_size_in_dp,
- ideal_icon_size_in_dp,
+ ShortcutHelper::GetIdealIconSizeInDp(),
+ ShortcutHelper::GetMinimumIconSizeInDp(),
+ ShortcutHelper::GetIdealSplashImageSizeInDp(),
+ ShortcutHelper::GetMinimumSplashImageSizeInDp(),
this)) {
java_ref_.Reset(env, obj);
}

Powered by Google App Engine
This is Rietveld 408576698