Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1559)

Unified Diff: chrome/browser/banners/app_banner_manager.h

Issue 1308533006: webapps: allow callers of icon downloader/selector to specify a minimum size (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@webapps-splashscreen-icon
Patch Set: Fix non-compiling test Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/banners/app_banner_manager.h
diff --git a/chrome/browser/banners/app_banner_manager.h b/chrome/browser/banners/app_banner_manager.h
index 97623e4fa2ac59aae3686df86de723cfb7c93fc5..09e3cd8b9cdf63a8b7899a72f00dd51bbfc80037 100644
--- a/chrome/browser/banners/app_banner_manager.h
+++ b/chrome/browser/banners/app_banner_manager.h
@@ -38,7 +38,7 @@ class AppBannerManager : public content::WebContentsObserver,
// Returns whether or not the URLs match for everything except for the ref.
static bool URLsAreForTheSamePage(const GURL& first, const GURL& second);
- explicit AppBannerManager(int ideal_icon_size_in_dp);
+ AppBannerManager();
~AppBannerManager() override;
// WebContentsObserver overrides.
@@ -51,21 +51,18 @@ class AppBannerManager : public content::WebContentsObserver,
const GURL& validated_url) override;
protected:
- AppBannerManager(content::WebContents* web_contents,
- int ideal_icon_size_in_dp);
+ explicit AppBannerManager(content::WebContents* web_contents);
void ReplaceWebContents(content::WebContents* web_contents);
// Creates an AppBannerDataFetcher, which constructs an app banner.
virtual AppBannerDataFetcher* CreateAppBannerDataFetcher(
- base::WeakPtr<AppBannerDataFetcher::Delegate> weak_delegate,
- const int ideal_icon_size_in_dp) = 0;
+ base::WeakPtr<AppBannerDataFetcher::Delegate> weak_delegate) = 0;
// Return whether the AppBannerDataFetcher is active.
bool IsFetcherActive();
scoped_refptr<AppBannerDataFetcher> data_fetcher() { return data_fetcher_; }
- int ideal_icon_size_in_dp() const { return ideal_icon_size_in_dp_; }
private:
// AppBannerDataFetcher::Delegate overrides.
@@ -83,9 +80,6 @@ class AppBannerManager : public content::WebContentsObserver,
// Cancels an active DataFetcher, stopping its banners from appearing.
void CancelActiveFetcher();
- // Ideal icon size to use.
- const int ideal_icon_size_in_dp_;
-
// The type of navigation made to the page
ui::PageTransition last_transition_type_;

Powered by Google App Engine
This is Rietveld 408576698