Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1439)

Unified Diff: chrome/browser/banners/app_banner_data_fetcher.h

Issue 1308533006: webapps: allow callers of icon downloader/selector to specify a minimum size (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@webapps-splashscreen-icon
Patch Set: Fix non-compiling test Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/banners/app_banner_data_fetcher.h
diff --git a/chrome/browser/banners/app_banner_data_fetcher.h b/chrome/browser/banners/app_banner_data_fetcher.h
index 6d06e56bfe0af61b9b4b6c632645c8f509c39a84..94be5d04c27886c3f2e48e6f004ff3c63560a002 100644
--- a/chrome/browser/banners/app_banner_data_fetcher.h
+++ b/chrome/browser/banners/app_banner_data_fetcher.h
@@ -57,7 +57,8 @@ class AppBannerDataFetcher
AppBannerDataFetcher(content::WebContents* web_contents,
base::WeakPtr<Delegate> weak_delegate,
- int ideal_icon_size_in_dp);
+ int ideal_icon_size_in_dp,
+ int minimum_icon_size_in_dp);
// Begins creating a banner for the URL being displayed by the Delegate's
// WebContents.
@@ -170,6 +171,7 @@ class AppBannerDataFetcher
content::WebContents* web_contents);
const int ideal_icon_size_in_dp_;
+ const int minimum_icon_size_in_dp_;
const base::WeakPtr<Delegate> weak_delegate_;
dominickn 2015/09/11 00:29:58 Nit: reorder these to put the int members after th
Lalit Maganti 2015/09/11 13:06:00 Done.
base::ObserverList<Observer> observer_list_;
bool is_active_;

Powered by Google App Engine
This is Rietveld 408576698